Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzzer for Convert.To/FromBase64 APIs #108247

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Sep 25, 2024

Add fuzzer for Convert.To/FromBase64*** APIs

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 25, 2024
@buyaa-n buyaa-n added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 25, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@lewing
Copy link
Member

lewing commented Sep 26, 2024

/azp run runtime

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Sep 26, 2024

@MihuBot fuzz ConvertToBase64

@MihaZupan
Copy link
Member

Fuzzing builds are currently broken as of #106599 being merged (+1 for #107204).

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Sep 27, 2024

Fuzzing builds are currently broken as of #106599 being merged (+1 for #107204).

Yes, the MihaBot failed with that issue, I am trying to fix that

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Oct 5, 2024

@MihuBot fuzz ConvertToBase64

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Oct 7, 2024

@MihuBot fuzz Base64

@@ -9,9 +9,7 @@
<AppHostSourcePath>$(ArtifactsDir)\bin\win-x64.Debug\corehost\apphost.exe</AppHostSourcePath>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<NoWarn>$(NoWarn);CS1591;IL3000;SYSLIB1054;CA1512;SYSLIB5005;</NoWarn>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this part intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since we set the IsTestSupportProject property in

<IsTestSupportProject>true</IsTestSupportProject>
these analyzer diagnostics are not hit on build, probably because we suppress warning on test build

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
@buyaa-n buyaa-n merged commit a0d5071 into dotnet:main Oct 8, 2024
86 checks passed
@buyaa-n buyaa-n deleted the conv-fuzz branch October 8, 2024 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants