Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0] Update sign-diagnostic-files.yml to skip dac sign in staging #108218

Merged
merged 2 commits into from
Sep 27, 2024
Merged

[release/9.0] Update sign-diagnostic-files.yml to skip dac sign in staging #108218

merged 2 commits into from
Sep 27, 2024

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Sep 24, 2024

No description provided.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

jeffschwMSFT
jeffschwMSFT approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can take this as tell mode

cc @carlossanlop

@hoyosjs hoyosjs added the Servicing-approved Approved for servicing release label Sep 27, 2024
@hoyosjs
Copy link
Member Author

hoyosjs commented Sep 27, 2024

Merging - this doesn't get hit in CI

@hoyosjs hoyosjs merged commit 3a9f86f into release/9.0 Sep 27, 2024
11 of 16 checks passed
@hoyosjs hoyosjs deleted the hoyosjs-patch-2 branch September 27, 2024 21:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@tommcdon tommcdon Awaiting requested review from tommcdon

Assignees

@hoyosjs hoyosjs

Labels
area-Infrastructure-coreclr Servicing-approved Approved for servicing release
Projects
Runtime Infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoyosjs @jeffschwMSFT