Skip to content

[release/9.0-rc2] Update configure.h.in #107955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2024
Merged

[release/9.0-rc2] Update configure.h.in #107955

merged 1 commit into from
Sep 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 17, 2024 •
edited by jkoritzinsky
Loading

Backport of #107954 to release/9.0-rc2

/cc @jkoritzinsky

Customer Impact

  • Customer reported
  • Found internally

dotnet --info outputs the following info for the host:

Host:
  Version:      9.0.0-rc.1.24431.7
  Architecture: x64
  Commit:       static

It should output the commit ID in the commit field.

Regression

  • Yes
  • No

Regressed in 9.0-preview 6

Testing

Manual build validation

Risk

Low. This only affects dotnet --info.

@jkoritzinsky
Update configure.h.in
da18e7e 
This symbol should be defined/not defined instead of defined as 0 or 1.

Fixes commit info for when running dotnet --info.
@ghost ghost added the area-Host label Sep 17, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

jeffschwMSFT
jeffschwMSFT approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please get a code review. we will take for consideration in rc2

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Sep 18, 2024
@jeffschwMSFT jeffschwMSFT added this to the 9.0.0 milestone Sep 18, 2024
@carlossanlop
Copy link
Contributor

/ba-g Dead lettering in System.Collections.Specialized.Tests (I've been seeing it in other PRs in the exact same tests).

@carlossanlop carlossanlop merged commit 8d6a573 into release/9.0-rc2 Sep 19, 2024
148 of 152 checks passed
@carlossanlop carlossanlop deleted the backport/pr-107954-to-release/9.0-rc2 branch September 19, 2024 01:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@hoyosjs hoyosjs hoyosjs approved these changes

Assignees
No one assigned
Labels
area-Host Servicing-approved Approved for servicing release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossanlop @jeffschwMSFT @hoyosjs @jkoritzinsky