-
Notifications
You must be signed in to change notification settings - Fork 5k
Disable event source in mobile sample apps #106880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Disable event source in mobile sample apps #106880
Conversation
Event source support is disabled by default by the iOS and Android SDKs, and ideally the sample app should match that behavior as closely as possible in general runtime functionality. The sample app is also used to measure app size, and so it should be representative of the defaults users will get when using SDK.
Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger |
We already have this code which sets the ~same default for testing: runtime/eng/testing/tests.mobile.targets Lines 34 to 40 in f402418
Would be nice to move this to extract this into a common .targets that we can import into the samples apps. |
What kind of feature switches would Browser/wasm sample apps want to turn off/on? For mobile sample apps, I think it would make sense to set an intersection of Android https://github.com/dotnet/android/blob/119d46c3a424ffeb3721718043616bfb10f5622f/src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets#L109-L120 and macios https://github.com/xamarin/xamarin-macios/blob/92092f67fdc0979b9db95bdef55a9c8280d383e4/dotnet/targets/Xamarin.Shared.Sdk.targets#L121-L136 settings. E.g.:
|
I agree with @akoeplinger |
Event source support is disabled by default by the iOS and Android SDKs, and ideally the sample app should match that behavior as closely as possible in general runtime functionality.
The sample app is also used to measure app size, and so it should be representative of the defaults users will get when using SDK.