Skip to content

Implement IEnumerator<T> on ref struct enumerators #106309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2025
Merged

Implement IEnumerator<T> on ref struct enumerators #106309

merged 2 commits into from
May 29, 2025
+734 −24

Conversation

AlexRadch
Copy link
Contributor

Close #105276

@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Aug 13, 2024
@ghost
Copy link

ghost commented Aug 13, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Aug 13, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 13, 2024
huoyaoyuan
huoyaoyuan reviewed Aug 13, 2024
View reviewed changes
This was referenced Aug 13, 2024
Closed
Open
Closed
Closed
@am11 am11 added area-System.Memory and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 13, 2024
This was referenced Aug 13, 2024
Open
Open
Open
Closed
Closed
Open
@build-analysis build-analysis bot mentioned this pull request Sep 11, 2024
Open
@build-analysis build-analysis bot mentioned this pull request Sep 6, 2024
Closed
This was referenced Jan 8, 2025
Open
Open
Closed
Open
Closed
Open
Open
stephentoub
stephentoub reviewed Feb 6, 2025
View reviewed changes
stephentoub
stephentoub reviewed Feb 6, 2025
View reviewed changes
This was referenced Mar 2, 2025
Open
Open
Open
@stephentoub stephentoub force-pushed the RefStructEnumerators branch from c78b1ea to d8a149f Compare May 28, 2025 19:09
This was referenced May 29, 2025
Open
Open
Open
@stephentoub stephentoub merged commit d960be8 into dotnet:main May 29, 2025
139 of 142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@huoyaoyuan huoyaoyuan Awaiting requested review from huoyaoyuan

Assignees
No one assigned
Labels
area-System.Memory community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Implement IEnumerator<T> on ref struct enumerators
4 participants
@AlexRadch @stephentoub @huoyaoyuan @am11