JIT: Model GetFfr* with a special side effect and handle it in VN#105973
Merged
jakobbotsch merged 4 commits intodotnet:mainfrom Aug 10, 2024
Merged
JIT: Model GetFfr* with a special side effect and handle it in VN#105973jakobbotsch merged 4 commits intodotnet:mainfrom
jakobbotsch merged 4 commits intodotnet:mainfrom
Conversation
- Add `HW_Flag_SpecialSideEffect_Other` to GetFfr* HW intrinsics. These intrinsics essentially read memory from memory that we do not model, so we have to treat them conservatively. - Teach VN to give all HW intrinsics with any special side effect a unique VN Fix dotnet#105944
Member
Author
|
cc @dotnet/jit-contrib PTAL @kunalspathak @TIHan @amanasifkhalid |
Member
Author
TIHan
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HW_Flag_SpecialSideEffect_Otherto GetFfr* HW intrinsics. These intrinsics essentially read memory from memory that we do not model, so we have to treat them conservatively.GTF_CALLandGTF_GLOB_REFtoGetFfr*HW intrinsics. We have to give these a conservative set of a flag to disallow the rest of the JIT from potentially reordering them withSetFfr.Fix #105944
In the test case head-merging reorders a
SetFfrwith aGetFfrsinceGetFfris not given appropriately conservative side effect flags: