Fix field offset not being set for 0-offset #105894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PersistedAssemblyBuilder didn't write field offset correctly when field offset was 0. This fixes that, and adds a test to ensure the behaviour is working. Fixes dotnet#105795
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
Contributor
Author
|
@dotnet-policy-service agree |
buyaa-n
reviewed
Aug 2, 2024
src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/ModuleBuilderImpl.cs
Show resolved
Hide resolved
buyaa-n
approved these changes
Aug 2, 2024
Contributor
buyaa-n
left a comment
buyaa-n
left a comment
There was a problem hiding this comment.
LGTM, thank you @TrueLunacy
Contributor
|
@ericstj @jeffhandley I would like to merge this bug fix found in new |
jeffhandley
approved these changes
Aug 3, 2024
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
Approved for RC1 merge (into main). Thanks, @TrueLunacy!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PersistedAssemblyBuilder didn't write field offset correctly when field offset was 0. This fixes that, and adds a test to ensure the behaviour is working.
Fixes #105795