Skip to content

Simplify platform attribute for AesGcm and ChaCha20Poly1305 #105547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2024
Merged

Simplify platform attribute for AesGcm and ChaCha20Poly1305 #105547

merged 1 commit into from
Jul 26, 2024

Conversation

akoeplinger
Copy link
Member

Follow-up to #105409, I verified the analyzer works correctly with just having the annotation for iOS.

@akoeplinger
Simplify platform attribute for AesGcm and ChaCha20Poly1305
c2903e0 
Follow-up to dotnet#105409, I verified the analyzer works correctly with just having the annotation for iOS.
@akoeplinger akoeplinger requested a review from vcsjones July 26, 2024 08:52
@ghost
Copy link

ghost commented Jul 26, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Jul 26, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Jul 26, 2024
Closed
@akoeplinger akoeplinger merged commit 9d7551e into dotnet:main Jul 26, 2024
@akoeplinger akoeplinger deleted the simplify-crypto branch July 26, 2024 20:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vcsjones vcsjones vcsjones approved these changes

@bartonjs bartonjs bartonjs approved these changes

Assignees

@akoeplinger akoeplinger

Labels
area-System.Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akoeplinger @vcsjones @bartonjs