Add JsonEnumMemberNameAttribute.#105032
Merged
eiriktsarpalis merged 14 commits intodotnet:mainfrom Jul 22, 2024
Merged
Conversation
|
Note regarding the |
1 similar comment
|
Note regarding the |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
eiriktsarpalis
commented
Jul 17, 2024
...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverter.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Jul 17, 2024
...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverter.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Jul 17, 2024
...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverter.cs
Show resolved
Hide resolved
eerhardt
reviewed
Jul 17, 2024
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/TrimmingTests/EnumConverterTest.cs
Show resolved
Hide resolved
This was referenced Jul 17, 2024
eiriktsarpalis
commented
Jul 18, 2024
src/libraries/System.Text.Json/tests/System.Text.Json.FSharp.Tests/EnumTests.fs
Show resolved
Hide resolved
jozkee
approved these changes
Jul 19, 2024
...System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverterFactory.cs
Show resolved
Hide resolved
...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverter.cs
Outdated
Show resolved
Hide resolved
...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverter.cs
Show resolved
Hide resolved
...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverter.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 19, 2024
Open
…ion/Converters/Value/EnumConverter.cs Co-authored-by: David Cantú <dacantu@microsoft.com>
This was referenced Jul 19, 2024
… validation; add more tests.
Member
Author
|
I've reworked the parsing implementation and refined the casing semantics and identifier validation logics. The implementation also improves performance substantially as this benchmark shows:
|
This was referenced Jul 20, 2024
jozkee
reviewed
Jul 22, 2024
...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverter.cs
Show resolved
Hide resolved
eerhardt
reviewed
Jul 22, 2024
src/libraries/System.Text.Json/src/System/Text/Json/JsonHelpers.cs
Outdated
Show resolved
Hide resolved
jozkee
reviewed
Jul 22, 2024
src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/EnumConverterTests.cs
Show resolved
Hide resolved
jozkee
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the following changes:
char-backed enum types that are possible in F#.Fix #74385. Pending API review.