Make ActivityRecorder more threadsafe #104888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
liveans
approved these changes
Jul 15, 2024
Member
liveans
left a comment
liveans
left a comment
There was a problem hiding this comment.
LGTM, assuming that CI passes
rzikm
deleted the
104883-`SystemNetSecurityTestsTelemetryTestSuccessfulHandshake_ActivityRecorded`-failures-in-CI
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104883.
Original issue appear because of race on
Started++. This PR replaces those withInterlocked.Incrementand adds a lock around_finishedActivitiescc @antonfirsov.