Don't use SyncTextWriter on WASI either#104798
Merged
akoeplinger merged 2 commits intodotnet:mainfrom Jul 15, 2024
Merged
Conversation
Follow-up to dotnet#101221 so we match behavior between single-threaded Browser and WASI.
ghost
added
the
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io |
pavelsavara
approved these changes
Jul 12, 2024
Member
|
we will need to do much broader consolidation in this regard. good start :) |
This was referenced Jul 12, 2024
Open
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Closed
Member
Author
|
/ba-g failures are fixed in #104888 which was merged after this PR was opened. |
This was referenced Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #101221 so we match behavior between single-threaded Browser and WASI.