Enable DiagnosticsTest for HTTP3 #104641
Merged
Enable DiagnosticsTest for HTTP3 #104641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
antonfirsov
commented
Jul 9, 2024
src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs
Show resolved
Hide resolved
ManickaP
approved these changes
Jul 10, 2024
stephentoub
approved these changes
Jul 10, 2024
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
Change looks fine, but there are related test failures
This was referenced Jul 10, 2024
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Closed
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #103922 (comment). Ideally, all existing DiagnosticsHandler tests should work, but we need to verify it on the CI.