Ensure mini-amd64 correctly handles CMP_GT and CMP_GE for OP_XCOMPARE_FP #104206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
tannergooding
added
area-Codegen-JIT-mono
and removed
needs-area-label
This was referenced Jun 30, 2024
Open
|
CC. @lambdageek this should be ready for review |
|
Also CC. @fanyang-mono since this touches the SIMD code |
|
No changes, just merging in latest from main |
This was referenced Jul 3, 2024
|
CI is now good, just the timeout leg that’s a known issue for WASM and reproducing on multiple PRs |
steveisok
approved these changes
Jul 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #97176