Arm64/Sve: Handle ConvertTo* APIs properly #103876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
@dotnet/arm64-contrib @amanasifkhalid PTAL @ebepho - For |
amanasifkhalid
approved these changes
Jun 24, 2024
|
|
||
| // For now, make sure that we get here only for intrinsics that we are | ||
| // sure about to rely on auxilary type's size. | ||
| assert((embOp->GetHWIntrinsicId() == NI_Sve_ConvertToInt32) || |
There was a problem hiding this comment.
Do you intend for this assert to go away once @ebepho implements ConvertToInt64, or should we keep checking for intrinsics with different base/return types? If the latter, I wonder if we ought to add a flag for these types of intrinsics.
There was a problem hiding this comment.
For now, we will update the assert, but may be later, we might consider adding a flag. For now, I want to see if there are more intrinsic categories that falls under this.
Co-authored-by: Aman Khalid <amankhalid@microsoft.com>
Co-authored-by: Aman Khalid <amankhalid@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were hitting an assert in these tests because we were not handling the wrapping of these intrinsics inside `ConditionalSelect.
ConvertTo*APIs get contained insideConditionalSelect. To do that we now store the auxiliary type as baseType of return vector and if that matches with the wrapped mask operation, then we contain the intrinsics.ConvertToInt32implements https://docsmirror.github.io/A64/2023-06/fcvtzu_z_p_z.html for following variants:FCVTZS <Zd>.S, <Pg>/M, <Zn>.SFCVTZS <Zd>.S, <Pg>/M, <Zn>.DConvertToUInt32implements https://docsmirror.github.io/A64/2023-06/fcvtzs_z_p_z.html for following variants:FCVTZU <Zd>.S, <Pg>/M, <Zn>.SFCVTZU <Zd>.S, <Pg>/M, <Zn>.D