Skip to content

Conversation

@jkoritzinsky
Copy link
Member

Create a portable box helper and remove the assembly-based one. The codegen is close, but we don't need to be exact as most box operations are inlined anyway

Follow-ups to #103055

…odegen is close, but we don't need to be exact as most box operations are inlined anyway
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thank you!

@jkotas
Copy link
Member

jkotas commented Jun 18, 2024

Arm32 is failing with asserts like: Assert failure(PID 20 [0x00000014], Thread: 38 [0x0026]): !CREATE_CHECK_STRING((((size_t)this) & 0x7) == (size_t)(pMT->IsValueType()?4:0))

Looks like a problem caused by FEATURE_64BIT_ALIGNMENT.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@jkotas
Copy link
Member

jkotas commented Jun 18, 2024

cc @elinor-fung for the cDAC change

Co-authored-by: Elinor Fung <elfung@microsoft.com>
@jkoritzinsky
Copy link
Member Author

/ba-g build failure is linked to a known test failure

@jkoritzinsky jkoritzinsky merged commit 117cfcc into dotnet:main Jun 20, 2024
@jkoritzinsky jkoritzinsky deleted the alloc-context-folllowup branch June 20, 2024 04:04
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants