System.Text.Json emits uncompilable code#103565
Merged
eiriktsarpalis merged 3 commits intodotnet:mainfrom Jun 17, 2024
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
stephentoub
approved these changes
Jun 17, 2024
Member
stephentoub
left a comment
There was a problem hiding this comment.
Should
change tois not as well?
Member
|
Thanks. Would it be possible to a couple of regression tests for the change as well? The relevant test suite can be found here: |
SteveDunn
commented
Jun 17, 2024
...tem.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Jun 17, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #103515