-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clrinterp: Add missing must-expand intrinsics #103326
Merged
EgorBo
merged 11 commits into
dotnet:main
from
EgorBo:fix-IsReferenceOrContainsReferences-interp
Jun 14, 2024
Merged
clrinterp: Add missing must-expand intrinsics #103326
EgorBo
merged 11 commits into
dotnet:main
from
EgorBo:fix-IsReferenceOrContainsReferences-interp
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Jun 12, 2024
EgorBo
changed the title
clrinterp: add IsReferenceOrContainsReferences intrinsic
clrinterp: Add missing must-expand intrinsics
Jun 12, 2024
jakobbotsch
reviewed
Jun 12, 2024
With these fixes, an empty app works. Something more complicated including
(note I disable W^X, EventSource, HWIntrinsics and R2R) |
jkotas
approved these changes
Jun 13, 2024
…OrContainsReferences-interp
This was referenced Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few intrinsics to coreclr's interpreter since these intrinsics are must-expand (and crash with StackOverflowException otherwise).