LSRA: Update paths to print kill registers in dumps #103303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
Author
|
@dotnet/jit-contrib @jakobbotsch PTAL |
jakobbotsch
approved these changes
Jun 11, 2024
This was referenced Jun 11, 2024
This was referenced Jun 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some paths that needed updates on how we print the kill register mask correctly. Also, I realized at many places
genFirstRegNumFromMask()andgenFirstRegNumFromMaskAndToggle()we were passingSingleTypeRegSetwithout passing the underlying register type and theSingleTypeRegSetwas implictely getting converted toregMaskTP. While this is not problematic currently but will soon be once we add predicate register. I want to put this PR separately as a cleanup item.