Skip to content

Don't run the new System.Net.ServerSentEvents test with NAOT - #103092

Closed
MichalStrehovsky wants to merge 1 commit into
mainfrom
MichalStrehovsky-patch-3
Closed

Don't run the new System.Net.ServerSentEvents test with NAOT#103092
MichalStrehovsky wants to merge 1 commit into
mainfrom
MichalStrehovsky-patch-3

Conversation

@MichalStrehovsky

Copy link
Copy Markdown
Member

Uses reflection-based JSON so it's unsupportable without someone writing a trimming descriptor.

Uses reflection-based JSON so it's unsupportable without someone writing a trimming descriptor.
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@stephentoub

Copy link
Copy Markdown
Member

Couldn't we instead change the test to use the source generator?

@MichalStrehovsky

Copy link
Copy Markdown
Member Author

Couldn't we instead change the test to use the source generator?

If this is something you would be willing to work on, I can file it as a bug and block the test on that. This test doesn't look to have interesting runtime interactions so I didn't plan to file a bug. The other bugs I filed for single file/trim/aot unfriendly testing in the past are in various backlogs so I just stopped filing them for non-essentials to save time.

This is just 1 out of 3 new outerloop test failures on native AOT legs in the past ~48 hours and I cannot justify spending too much time on these because it's a never ending stream.

@stephentoub

Copy link
Copy Markdown
Member

If this is something you would be willing to work on

#103126 merged. Hopefully that fixed it.

@MichalStrehovsky

Copy link
Copy Markdown
Member Author

#103126 merged. Hopefully that fixed it.

Thank you!

@MichalStrehovsky
MichalStrehovsky deleted the MichalStrehovsky-patch-3 branch June 6, 2024 22:46
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants