Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run the new System.Net.ServerSentEvents test with NAOT #103092

Closed
wants to merge 1 commit into from

Conversation

MichalStrehovsky
Copy link
Member

Uses reflection-based JSON so it's unsupportable without someone writing a trimming descriptor.

Uses reflection-based JSON so it's unsupportable without someone writing a trimming descriptor.
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member

Couldn't we instead change the test to use the source generator?

@MichalStrehovsky
Copy link
Member Author

Couldn't we instead change the test to use the source generator?

If this is something you would be willing to work on, I can file it as a bug and block the test on that. This test doesn't look to have interesting runtime interactions so I didn't plan to file a bug. The other bugs I filed for single file/trim/aot unfriendly testing in the past are in various backlogs so I just stopped filing them for non-essentials to save time.

This is just 1 out of 3 new outerloop test failures on native AOT legs in the past ~48 hours and I cannot justify spending too much time on these because it's a never ending stream.

@stephentoub
Copy link
Member

If this is something you would be willing to work on

#103126 merged. Hopefully that fixed it.

@MichalStrehovsky
Copy link
Member Author

#103126 merged. Hopefully that fixed it.

Thank you!

@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-3 branch June 6, 2024 22:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants