Skip to content

[release/6.0-staging] Merge #92901 #102862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

amanasifkhalid
Copy link
Member

@amanasifkhalid amanasifkhalid commented May 30, 2024

This continues replicating @eduardo-vp's 1ES port work for the .NET 6 servicing branch by merging #92901. I had to do this by hand to contend with the divergence between release/6.0-staging and main; in addition to #92901's changes, I cherry-picked small changes from other (otherwise-unrelated) PRs to simplify the merge -- the removal of eng/pipelines/installer/installer-matrix.yml in favor of eng/pipelines/common/platform-matrix.yml is one such change.

Official build

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 30, 2024
@amanasifkhalid amanasifkhalid added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 30, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid amanasifkhalid changed the title [release/6.0-staging] Merge #92091 [release/6.0-staging] Merge #92901 May 30, 2024
@amanasifkhalid amanasifkhalid marked this pull request as ready for review May 31, 2024 19:10
@amanasifkhalid
Copy link
Member Author

@jkoritzinsky @agocke PTAL. Failures are known. Thanks!

@amanasifkhalid
Copy link
Member Author

ping @jkoritzinsky @agocke

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can take this as tell mode

cc @carlossanlop

@amanasifkhalid amanasifkhalid added the Servicing-approved Approved for servicing release label Jun 4, 2024
@amanasifkhalid amanasifkhalid merged commit f71677a into dotnet:release/6.0-staging Jun 4, 2024
150 of 156 checks passed
@amanasifkhalid amanasifkhalid deleted the merge-92091 branch June 4, 2024 17:44
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants