Skip to content

Add OverloadResolutionPriorityAttribute #102176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2024
Merged

Add OverloadResolutionPriorityAttribute #102176

merged 3 commits into from
May 15, 2024

Conversation

333fred
Copy link
Member

@333fred 333fred commented May 13, 2024 •
edited by jcouv
Loading

Closes #102173.
Relates to test plan dotnet/roslyn#74131

@ghost
Copy link

ghost commented May 13, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

@333fred 333fred force-pushed the dev/333fred/overloadresolutionpriority branch 2 times, most recently from bbfd2f8 to 329e89e Compare May 13, 2024 22:08
This was referenced May 14, 2024
Closed
Closed
stephentoub
stephentoub approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephentoub stephentoub marked this pull request as ready for review May 14, 2024 19:15
@333fred 333fred force-pushed the dev/333fred/overloadresolutionpriority branch from c0cc073 to b9681ed Compare May 14, 2024 20:02
@build-analysis build-analysis bot mentioned this pull request May 15, 2024
Open
@stephentoub stephentoub mentioned this pull request May 15, 2024
Closed
@stephentoub
Copy link
Member

/ba-g widespread unrelated CI timeouts

@stephentoub stephentoub merged commit 09dd34e into main May 15, 2024
130 of 146 checks passed
@stephentoub stephentoub deleted the dev/333fred/overloadresolutionpriority branch May 15, 2024 03:02
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@333fred @Ruihan-Yin
Add OverloadResolutionPriorityAttribute (dotnet#102176)
5aae3b6 
* Add OverloadResolutionPriorityAttribute

Closes dotnet#102173.

* Base types

* Switch from primary ctor to regular ctor, add docs.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@333fred 333fred

Labels
area-System.Runtime.CompilerServices new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: OverloadResolutionPriorityAttribute
2 participants
@333fred @stephentoub