Refactor AdvSimd version of DecodeFromUTF8#101620
Merged
kunalspathak merged 4 commits intodotnet:mainfrom May 9, 2024
Merged
Conversation
Contributor
SwapnilGaikwad
commented
Apr 26, 2024
- Add more comments to describe the decode algorithm
- Addresses comments from Use multi-reg load/store for DecodeFromUTF8 #100589
Contributor
Author
|
@a74nh @kunalspathak @dotnet/arm64-contrib |
Contributor
Author
|
There is no notable performance difference on a V1 and N1 system for this patch. Assembly sequence for DecodeFromUtf8 |
This was referenced Apr 26, 2024
kunalspathak
suggested changes
May 2, 2024
src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs
Show resolved
Hide resolved
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-buffers |
kunalspathak
suggested changes
May 8, 2024
Contributor
kunalspathak
left a comment
There was a problem hiding this comment.
Added some questions/comments.
src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Base64Decoder.cs
Show resolved
Hide resolved
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
* Refactor AdvSimd version of DecodeFromUTF8 * Refactor look-up table for readability * Fix the comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.