Notify the debugger of a cross-thread dependency in Lock#101501
Merged
kouvel merged 2 commits intodotnet:mainfrom May 2, 2024
kouvel:LockFuncEvalFix
Merged
Notify the debugger of a cross-thread dependency in Lock#101501kouvel merged 2 commits intodotnet:mainfrom kouvel:LockFuncEvalFix
kouvel merged 2 commits intodotnet:mainfrom
kouvel:LockFuncEvalFix
Conversation
When a FuncEval tries to acquire a Lock that is held by a different thread, notify the debugger of a cross-thread dependency.
Contributor
|
Tagging subscribers to this area: @mangod9 |
Contributor
Author
|
CC @tommcdon. I tried testing this locally and wasn't seeing an early abort, may be due to a different issue. Anyway based on the intent I believe this should enable an early abort. |
Contributor
Author
|
With a small change to testing, I was able to verify that this works to enable quick-abort of a FuncEval when it attempts to acquire a contented lock. Thanks @tommcdon! |
This was referenced Apr 24, 2024
Closed
Closed
Closed
Closed
This was referenced Apr 25, 2024
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
* Notify the debugger of a cross-thread dependency in Lock When a FuncEval tries to acquire a Lock that is held by a different thread, notify the debugger of a cross-thread dependency.
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
* Notify the debugger of a cross-thread dependency in Lock When a FuncEval tries to acquire a Lock that is held by a different thread, notify the debugger of a cross-thread dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a FuncEval tries to acquire a Lock that is held by a different thread, notify the debugger of a cross-thread dependency.