[mono] UnsafeAccessor: Add support for generic method instance#101442
Merged
fanyang-mono merged 5 commits intodotnet:mainfrom Apr 27, 2024
Merged
[mono] UnsafeAccessor: Add support for generic method instance#101442fanyang-mono merged 5 commits intodotnet:mainfrom
fanyang-mono merged 5 commits intodotnet:mainfrom
Conversation
fanyang-mono
requested review from
lambdageek,
steveisok and
thaystg
as code owners
ghost
added
the
6 tasks
Member
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Apr 23, 2024
Closed
Closed
Member
Author
|
All CI failures are known, including the ones on |
This was referenced Apr 24, 2024
Closed
lewing
approved these changes
Apr 26, 2024
Member
lewing
left a comment
lewing
left a comment
There was a problem hiding this comment.
CI and reenabled tests are green
lambdageek
approved these changes
Apr 26, 2024
Member
lambdageek
left a comment
lambdageek
left a comment
There was a problem hiding this comment.
LGTM. we can clean up some boilerplate, though
lambdageek
reviewed
Apr 26, 2024
lambdageek
reviewed
Apr 26, 2024
This was referenced Apr 26, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
…otnet#101442) * Support non generic instance * Create helper function for shared code * Use an existing API * Add an assert --------- Co-authored-by: Larry Ewing <lewing@microsoft.com>
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
…otnet#101442) * Support non generic instance * Create helper function for shared code * Use an existing API * Add an assert --------- Co-authored-by: Larry Ewing <lewing@microsoft.com>
fanyang-mono
changed the title
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…otnet#101442) * Support non generic instance * Create helper function for shared code * Use an existing API * Add an assert --------- Co-authored-by: Larry Ewing <lewing@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #99830