Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] UnsafeAccessor: Add support for generic method instance #101442

Merged
merged 5 commits into from
Apr 27, 2024

Conversation

fanyang-mono
Copy link
Member

Contributes to #99830

@lambdageek
Copy link
Member

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fanyang-mono
Copy link
Member Author

All CI failures are known, including the ones on runtime-extra-platforms.

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI and reenabled tests are green

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we can clean up some boilerplate, though

src/mono/mono/metadata/marshal-lightweight.c Outdated Show resolved Hide resolved
src/mono/mono/metadata/marshal-lightweight.c Outdated Show resolved Hide resolved
src/mono/mono/metadata/marshal-lightweight.c Outdated Show resolved Hide resolved
@fanyang-mono fanyang-mono merged commit 6f549af into dotnet:main Apr 27, 2024
123 of 127 checks passed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
…otnet#101442)

* Support non generic instance

* Create helper function for shared code

* Use an existing API

* Add an assert

---------

Co-authored-by: Larry Ewing <lewing@microsoft.com>
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
…otnet#101442)

* Support non generic instance

* Create helper function for shared code

* Use an existing API

* Add an assert

---------

Co-authored-by: Larry Ewing <lewing@microsoft.com>
@fanyang-mono fanyang-mono changed the title [mono] UnsafeAccessor: Add support for non-generic method instance [mono] UnsafeAccessor: Add support for generic method instance May 20, 2024
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
…otnet#101442)

* Support non generic instance

* Create helper function for shared code

* Use an existing API

* Add an assert

---------

Co-authored-by: Larry Ewing <lewing@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants