Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][MT] stop doing grow(0) #101248

Closed
wants to merge 2 commits into from

Conversation

pavelsavara
Copy link
Member

see what breaks

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Apr 18, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Apr 18, 2024
@pavelsavara pavelsavara self-assigned this Apr 18, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member Author

This is why we need grow(0)

Log

[18:06:20] info: Assembly: System.Reflection.Context.Tests, Version=9.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 (System.Reflection.Context.Tests.dll)
[18:06:20] fail: [worker-idle 18:06:20.491] MONO_WASM: Unhandled error: RangeError: Invalid atomic access index
[18:06:20] fail: [worker-idle 18:06:20.574] MONO_WASM: Invalid atomic access index
                 RangeError: Invalid atomic access index
                     at Atomics.waitAsync (<anonymous>)
                     at Object.__emscripten_thread_mailbox_await (http://127.0.0.1:41991/_framework/dotnet.native.js:8:102771)
                     at handleMessage (http://127.0.0.1:41991/_framework/dotnet.native.worker.js:1:2103)

I will keep this PR until we could also test in on FF
And also I would be interested to see if latest emscripten has the same issue

cc @kg @radekdoulik

@pavelsavara pavelsavara added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 19, 2024
# Conflicts:
#	src/mono/browser/runtime/cancelable-promise.ts
#	src/mono/browser/runtime/marshal.ts
#	src/mono/browser/runtime/memory.ts
#	src/mono/browser/runtime/scheduling.ts
#	src/mono/browser/runtime/web-socket.ts
@pavelsavara
Copy link
Member Author

Here is firefox version of the same problem Log

JavaScript error: http://127.0.0.1:36241/_framework/dotnet.native.wasm, line 157841: RuntimeError: index out of bounds

grow(0) helps with it on firefox too. Is that strange ?
cc @kg

Copy link
Contributor

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
@pavelsavara pavelsavara deleted the browser_mt_dont_grow0 branch September 2, 2024 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant