Move first chance exception notification so the !pe works #101190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent addition of first chance exception notification for the new EH was comming too early, so when the notification occurred, the !pe SOS command was not able to get the actual exception yet - it was not accessible via the Thread::ExceptionState This change moves the notification to the first spot where the exception state points to the exception, so the !pe works.
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
) The recent addition of first chance exception notification for the new EH was comming too early, so when the notification occurred, the !pe SOS command was not able to get the actual exception yet - it was not accessible via the Thread::ExceptionState This change moves the notification to the first spot where the exception state points to the exception, so the !pe works.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent addition of first chance exception notification for the new EH was comming too early, so when the notification occurred, the !pe SOS command was not able to get the actual exception yet - it was not accessible via the Thread::ExceptionState
This change moves the notification to the first spot where the exception state points to the exception, so the !pe works.