[cdac] Make DAC load and use cDAC when available#100946
[cdac] Make DAC load and use cDAC when available#100946elinor-fung merged 17 commits intodotnet:mainfrom
Conversation
|
Tagging subscribers to this area: @tommcdon |
4387e85 to
2d04884
Compare
2d04884 to
7b6d1b2
Compare
jkoritzinsky
left a comment
There was a problem hiding this comment.
This current model would require each implementation in the existing DAC of the ISOSDacInterfaceX interfaces to be edited each time a new method is implemented in the cDAC. Could we implement this using a COM Aggregation object that implements all the interface methods by calling the cDAC first and then calling the DAC implementation instead of updating each method implementation in the DAC?
That was actually my original plan. After getting in there and seeing just how many methods there were and how many of them don't seem relevant any more, I wasn't sure it was worth it. But maybe we start to implement more and decide it is. I could go either way. |
Co-authored-by: Aaron Robinson <arobins@microsoft.com> Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
- If `DOTNET_ENABLE_CDAC` environment variable is `1`, Look for `cdacreader` next to DAC and load it if found - Implement `ISOSDacInterface` in cDAC - currently returns `E_NOTIMPL` for everything - Make DAC delegate to cDAC (if available) for GetThreadStoreData and GetBreakingChangeVersion - Initialize cDAC with function for reading from the target
DOTNET_ENABLE_CDACenvironment variable is1, Look forcdacreadernext to DAC and load it if foundISOSDacInterfacein cDAC - currently returnsE_NOTIMPLfor everythingContributes to #99298
Resolves #99301