[mono] Optimize mono_metadata_type_dup_with_cmods#100849
Merged
kg merged 1 commit intodotnet:mainfrom Apr 10, 2024
Merged
Conversation
ghost
added
the
This was referenced Apr 10, 2024
lambdageek
approved these changes
Apr 10, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
mono_metadata_type_dup_with_cmods is a minor hotspot during WASM startup, so apply some minor optimizations to it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During startup we spend a measurable amount of time duplicating types, and this function in particular is kind of wasteful to the extent that the redundant memset and memcpy operations show up in profiles. I rearranged things a bit so it should touch most bytes of the result only once or twice instead of the 3+ times it currently does. 0.71% -> 0.57%