Drop generic type constraints from Unsafe.BitCast#100842
Merged
tannergooding merged 7 commits intodotnet:mainfrom Apr 15, 2024
Merged
Drop generic type constraints from Unsafe.BitCast#100842tannergooding merged 7 commits intodotnet:mainfrom
tannergooding merged 7 commits intodotnet:mainfrom
Conversation
|
Note regarding the |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices |
jkotas
reviewed
Apr 10, 2024
jkotas
reviewed
Apr 11, 2024
179ba2f to
1210d9a
Compare
This was referenced Apr 15, 2024
Closed
Closed
jkotas
reviewed
Apr 15, 2024
This was referenced Apr 15, 2024
tannergooding
approved these changes
Apr 15, 2024
Member
|
FYI @dotnet/jit-contrib (JIT-EE GUID changed) |
Member
|
Sorry, I had thought jit-contrib had already been tagged above but now I see the area tag ended up being |
Member
|
Another potentially related regression issue @MihaZupan |
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* Drop generic type constraints from Unsafe.BitCast * Add isNullableType to JIT interface * superpmi * Comment formatting * Check IsGenericParameter instead of Canon * Replace IsGenericParameter check with assert * Just kidding, remove it completely :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99205
Fixes #99006
MihuBot/runtime-utils#354
Most diffs appear to be more inlining / removing unreachable branches. For example seeing that these
IndexOf*calls are passing in 0 and therefore deleting the checks and unreachable calls toPackedSpanHelpersruntime/src/libraries/System.Net.Http/src/System/Net/Http/Headers/UriHeaderParser.cs
Lines 65 to 67 in 3462976
Part of the diff