Skip to content

[browser][MT] improve abort on web worker#100610

Merged
pavelsavara merged 5 commits intodotnet:mainfrom
pavelsavara:browser_mt_js_exceptions_2
Apr 9, 2024
Merged

[browser][MT] improve abort on web worker#100610
pavelsavara merged 5 commits intodotnet:mainfrom
pavelsavara:browser_mt_js_exceptions_2

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Apr 3, 2024 •
edited
Loading

  • replace mono_wasm_abort with Module.abort to be able to pass reason string
  • register onAbort and onExit also on worker
  • improve stack trace reporting across threads
  • _emscripten_force_exit if the UI thread is spin-waiting
    • trigger it 3000ms after critical mono_wasm_trace_logger like g_assert
    • trigger it 3000ms after nativeAbort
  • fix error formatting
  • max delay for teardown_proxy_console 3000ms
  • only print WASM EXIT on UI thread
  • rename cancelThreads to postCancelThreads
  • move mono_wasm_install_js_worker_interop and mono_wasm_uninstall_js_worker_interop to file worker-interop.ts
  • nativeAbort now also calls terminateAllThreads on UI thread
  • report navigator.userAgent during test-main.js to be able to validate browser version

Contributes to #98309
Contributes to #99888
Contributes to #100249

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Apr 3, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Apr 3, 2024
@pavelsavara pavelsavara self-assigned this Apr 3, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Apr 3, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 4, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@pavelsavara pavelsavara force-pushed the browser_mt_js_exceptions_2 branch from 556e4b1 to 7dc5c3a Compare April 8, 2024 11:39
This was referenced Apr 8, 2024
Closed
Closed
@pavelsavara pavelsavara marked this pull request as ready for review April 8, 2024 17:45
@pavelsavara pavelsavara requested a review from lewing as a code owner April 8, 2024 17:45
@pavelsavara pavelsavara requested review from ilonatommy and maraf April 8, 2024 17:46
@pavelsavara pavelsavara mentioned this pull request Apr 9, 2024
Closed
@pavelsavara
Merge branch 'main' into browser_mt_js_exceptions_2
435db97 
# Conflicts:
#	src/mono/browser/runtime/pthreads/index.ts
@pavelsavara
Merge branch 'main' into browser_mt_js_exceptions_2
8a42a86 
# Conflicts:
#	src/mono/browser/runtime/types/internal.ts
@pavelsavara
Copy link
Member Author

pavelsavara commented Apr 9, 2024

Part of the failures are #100275
I also filed new #100831 which is uncovered by this PR

@pavelsavara pavelsavara merged commit 552b5e9 into dotnet:main Apr 9, 2024
@pavelsavara pavelsavara deleted the browser_mt_js_exceptions_2 branch April 9, 2024 17:59
This was referenced Apr 9, 2024
Closed
Closed
This was referenced Apr 15, 2024
Closed
Closed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@pavelsavara @matouskozak
[browser][MT] improve abort on web worker (dotnet#100610)
9ac5195
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@maraf maraf maraf approved these changes

@ilonatommy ilonatommy ilonatommy approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelsavara @maraf @ilonatommy