-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Console.Unix: revert SetWindowSize implementation. #100272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ff9fe1c
091ceca
059f2c4
dca62ef
90fe4aa
26ceecf
43a7290
3deb479
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,24 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>M:System.Console.SetWindowSize(System.Int32,System.Int32):[T:System.Runtime.Versioning.UnsupportedOSPlatformAttribute]</Target> | ||
<Left>net8.0/mscorlib.dll</Left> | ||
<Right>net9.0/mscorlib.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>P:System.Console.WindowHeight:[T:System.Runtime.Versioning.UnsupportedOSPlatformAttribute]</Target> | ||
<Left>net8.0/mscorlib.dll</Left> | ||
<Right>net9.0/mscorlib.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>P:System.Console.WindowWidth:[T:System.Runtime.Versioning.UnsupportedOSPlatformAttribute]</Target> | ||
<Left>net8.0/mscorlib.dll</Left> | ||
<Right>net9.0/mscorlib.dll</Right> | ||
</Suppression> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How was this generated? I tried as described in #75824 (comment) but didn't get any changes related to Console. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I think the comment you linked to had a different property name. The one listed in the error message and shared here should be the right one: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also these are all CP0014 - they are what I'd expect for the attribute changes to the reference assembly. If you're OK with those changes then these are fine (so long as build passes they are in sync). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for checking them out. Btw, this is what I get from running dotnet.cmd:
|
||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>M:System.ComponentModel.DesignerAttribute.#ctor(System.String,System.String)$0:[T:System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembersAttribute]</Target> | ||
|
@@ -91,6 +109,12 @@ | |
<Left>net8.0/netstandard.dll</Left> | ||
<Right>net9.0/netstandard.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>M:System.Console.SetWindowSize(System.Int32,System.Int32):[T:System.Runtime.Versioning.UnsupportedOSPlatformAttribute]</Target> | ||
<Left>net8.0/netstandard.dll</Left> | ||
<Right>net9.0/netstandard.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>P:System.ComponentModel.DesignerAttribute.DesignerBaseTypeName:[T:System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembersAttribute]</Target> | ||
|
@@ -121,6 +145,18 @@ | |
<Left>net8.0/netstandard.dll</Left> | ||
<Right>net9.0/netstandard.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>P:System.Console.WindowHeight:[T:System.Runtime.Versioning.UnsupportedOSPlatformAttribute]</Target> | ||
<Left>net8.0/netstandard.dll</Left> | ||
<Right>net9.0/netstandard.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>P:System.Console.WindowWidth:[T:System.Runtime.Versioning.UnsupportedOSPlatformAttribute]</Target> | ||
<Left>net8.0/netstandard.dll</Left> | ||
<Right>net9.0/netstandard.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>M:System.ComponentModel.DesignerAttribute.#ctor(System.String,System.String)$0:[T:System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembersAttribute]</Target> | ||
|
@@ -349,6 +385,24 @@ | |
<Left>net8.0/System.ComponentModel.TypeConverter.dll</Left> | ||
<Right>net9.0/System.ComponentModel.TypeConverter.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>M:System.Console.SetWindowSize(System.Int32,System.Int32):[T:System.Runtime.Versioning.UnsupportedOSPlatformAttribute]</Target> | ||
<Left>net8.0/System.Console.dll</Left> | ||
<Right>net9.0/System.Console.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>P:System.Console.WindowHeight:[T:System.Runtime.Versioning.UnsupportedOSPlatformAttribute]</Target> | ||
<Left>net8.0/System.Console.dll</Left> | ||
<Right>net9.0/System.Console.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>P:System.Console.WindowWidth:[T:System.Runtime.Versioning.UnsupportedOSPlatformAttribute]</Target> | ||
<Left>net8.0/System.Console.dll</Left> | ||
<Right>net9.0/System.Console.dll</Right> | ||
</Suppression> | ||
<Suppression> | ||
<DiagnosticId>CP0014</DiagnosticId> | ||
<Target>M:System.ComponentModel.DesignerAttribute.#ctor(System.String,System.String)$0:[T:System.Diagnostics.CodeAnalysis.DynamicallyAccessedMembersAttribute]</Target> | ||
|
Uh oh!
There was an error while loading. Please reload this page.