Skip to content

[wasm] Bump chrome for testing - linux: 123.0.6312.58, windows: 123.0.6312.58 #100084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2024
Merged

[wasm] Bump chrome for testing - linux: 123.0.6312.58, windows: 123.0.6312.58 #100084

merged 4 commits into from
Mar 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@github-actions github-actions bot added arch-wasm WebAssembly architecture area-Infrastructure-mono labels Mar 21, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@ilonatommy
Copy link
Member

ilonatommy commented Mar 21, 2024 •
edited
Loading

It's not correct, win_ChromeRevision should not be the same as linux_ChromeRevision, currently it's Win_x64/1000027 (https://storage.googleapis.com/chromium-browser-snapshots?prefix=Win_x64) and Linux_x64/023ca1a208be4349534e73032671f4ee8004e553 or Linux_x64/1262506 (https://storage.googleapis.com/chromium-browser-snapshots?prefix=Linux_x64). It will be fixed in another PR.

Edit:
Now I understand what's the problem. We are not bumping the versions each time they are released but we are doing it for stable versions only. The last stable version for Windows (https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1250580/.....) is not available on the server (there's 1250557 and then 1250586) . In this context, the query argument is preventing from getting information about snapshot availability - it always returns non-error, even when the snapshot is not there.

@ilonatommy ilonatommy added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 21, 2024
@ilonatommy ilonatommy self-assigned this Mar 21, 2024
@build-analysis build-analysis bot mentioned this pull request Mar 21, 2024
Closed
@github-actions github-actions bot requested a review from akoeplinger as a code owner March 22, 2024 09:32
@ilonatommy ilonatommy removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Mar 22, 2024
kg
kg reviewed Mar 22, 2024
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Mar 22, 2024
Closed
@ilonatommy ilonatommy merged commit 330b70c into main Mar 25, 2024
@jkotas jkotas deleted the update-chrome-version-8378083966 branch March 31, 2024 15:28
@lewing lewing mentioned this pull request Apr 10, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kg kg kg approved these changes

@pavelsavara pavelsavara pavelsavara approved these changes

@ilonatommy ilonatommy Awaiting requested review from ilonatommy

@lewing lewing Awaiting requested review from lewing

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@radical radical Awaiting requested review from radical

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilonatommy @kg @pavelsavara