Sometimes `testhost/CoreRun` crashes with `System.Diagnostics.Tracing`-related assertion failure

[karakasa]

Description

testhost/CoreRun sometimes crashes for a blank console app.

Reproduction Steps

1. Clone the latest repo and build it using build -rc Debug.
2. Use testhost\CoreRun to run a blank Console App (dll).

The crash doesn't always happen.

Expected behavior

CoreRun runs without issues.

Actual behavior

CoreRun crashes.

stack

Process terminated. Assertion failed.
   at System.Diagnostics.Tracing.CounterGroup.OnEventSourceCommand(Object sender, EventCommandEventArgs e)
   at System.Diagnostics.Tracing.EventSource.add_EventCommandExecuted(EventHandler`1 value)
   at System.Diagnostics.Tracing.CounterGroup.RegisterCommandCallback()
   at System.Diagnostics.Tracing.CounterGroup..ctor(EventSource eventSource)
   at System.Diagnostics.Tracing.CounterGroup.GetCounterGroup(EventSource eventSource)
   at System.Diagnostics.Tracing.DiagnosticCounter.Publish()
   at System.Diagnostics.Tracing.PollingCounter..ctor(String name, EventSource eventSource, Func`1 metricProvider)
   at System.Diagnostics.Tracing.RuntimeEventSource.OnEventCommand(EventCommandEventArgs command)
   at System.Diagnostics.Tracing.EventSource.DoCommand(EventCommandEventArgs commandArgs)
   at System.Diagnostics.Tracing.EventSource.Initialize(Guid eventSourceGuid, String eventSourceName, String[] traits)
   at System.Diagnostics.Tracing.EventSource..ctor(Guid eventSourceGuid, String eventSourceName, EventSourceSettings settings, String[] traits)
   at System.Diagnostics.Tracing.RuntimeEventSource..ctor()
   at System.Diagnostics.Tracing.RuntimeEventSource.Initialize()
   at System.StartupHookProvider.ManagedStartup(Char* pDiagnosticStartupHooks)

Regression?

I never run into such issues in the past half a year. It started after I updated the local repo to the latest last afternoon.

Known Workarounds

Rebooting Windows usually resolves the issue. But sometimes it occurs again after a period of usage.

Configuration

Local .NET: 8 RC1
OS: Windows 10 x64 22H2

Other information

Visual Studio debugger shows the assertion here fails.

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/CounterGroup.cs

Line 50 in 0976df5

Debug.Assert(e.Command == EventCommand.Enable || e.Command == EventCommand.Disable);

the unhandled Update seems coming from:

runtime/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventProvider.cs

Line 810 in 0976df5

ControllerCommand command = ControllerCommand.Update;

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

testhost/CoreRun crashes sometimes, regardless of what it runs.

Reproduction Steps

1. Clone the latest repo and build it
2. Use testhost\CoreRun to run a blank Console App (dll) (or anything else).

The crash doesn't always happen.

Expected behavior

CoreRun runs without issues.

Actual behavior

CoreRun crashes.

Process terminated. Assertion failed.
   at System.Diagnostics.Tracing.CounterGroup.OnEventSourceCommand(Object sender, EventCommandEventArgs e)
   at System.Diagnostics.Tracing.EventSource.add_EventCommandExecuted(EventHandler`1 value)
   at System.Diagnostics.Tracing.CounterGroup.RegisterCommandCallback()
   at System.Diagnostics.Tracing.CounterGroup..ctor(EventSource eventSource)
   at System.Diagnostics.Tracing.CounterGroup.GetCounterGroup(EventSource eventSource)
   at System.Diagnostics.Tracing.DiagnosticCounter.Publish()
   at System.Diagnostics.Tracing.PollingCounter..ctor(String name, EventSource eventSource, Func`1 metricProvider)
   at System.Diagnostics.Tracing.RuntimeEventSource.OnEventCommand(EventCommandEventArgs command)
   at System.Diagnostics.Tracing.EventSource.DoCommand(EventCommandEventArgs commandArgs)
   at System.Diagnostics.Tracing.EventSource.Initialize(Guid eventSourceGuid, String eventSourceName, String[] traits)
   at System.Diagnostics.Tracing.EventSource..ctor(Guid eventSourceGuid, String eventSourceName, EventSourceSettings settings, String[] traits)
   at System.Diagnostics.Tracing.RuntimeEventSource..ctor()
   at System.Diagnostics.Tracing.RuntimeEventSource.Initialize()
   at System.StartupHookProvider.ManagedStartup(Char* pDiagnosticStartupHooks)

Regression?

I never run into such issues in the past half a year. It started after I updated the local repo to the latest last afternoon.

Known Workarounds

Rebooting Windows usually resolves the issue. But sometimes it occurs again after a period of usage.

Configuration

Local .NET: 8 RC1
OS: Windows 10 x64 22H2

Other information

No response

Author:	karakasa
Assignees:	-
Labels:	area-System.Diagnostics.Tracing
Milestone:	-

[tarekgh]

@davmason could you have a look or get someone to triage this one? Thanks!

CC @@noahfalk

[karakasa]

hi @davmason

Somehow this issue becomes very frequent today. I would like to perform a local hack. Is it safe to just ignore the Update event in CounterGroup.OnEventSourceCommand?

[davmason]

Hi @karakasa, it should be safe to remove the Debug.Assert before you build. I'd like to understand the failure though, do you have the callstack of where it is crashing?

[karakasa]

have the callstack of where it is crashing?

ah. I put it in a <details> block.

Process terminated. Assertion failed.
   at System.Diagnostics.Tracing.CounterGroup.OnEventSourceCommand(Object sender, EventCommandEventArgs e)
   at System.Diagnostics.Tracing.EventSource.add_EventCommandExecuted(EventHandler`1 value)
   at System.Diagnostics.Tracing.CounterGroup.RegisterCommandCallback()
   at System.Diagnostics.Tracing.CounterGroup..ctor(EventSource eventSource)
   at System.Diagnostics.Tracing.CounterGroup.GetCounterGroup(EventSource eventSource)
   at System.Diagnostics.Tracing.DiagnosticCounter.Publish()
   at System.Diagnostics.Tracing.PollingCounter..ctor(String name, EventSource eventSource, Func`1 metricProvider)
   at System.Diagnostics.Tracing.RuntimeEventSource.OnEventCommand(EventCommandEventArgs command)
   at System.Diagnostics.Tracing.EventSource.DoCommand(EventCommandEventArgs commandArgs)
   at System.Diagnostics.Tracing.EventSource.Initialize(Guid eventSourceGuid, String eventSourceName, String[] traits)
   at System.Diagnostics.Tracing.EventSource..ctor(Guid eventSourceGuid, String eventSourceName, EventSourceSettings settings, String[] traits)
   at System.Diagnostics.Tracing.RuntimeEventSource..ctor()
   at System.Diagnostics.Tracing.RuntimeEventSource.Initialize()
   at System.StartupHookProvider.ManagedStartup(Char* pDiagnosticStartupHooks)

[davmason]

Hi again @karakasa!

I spent some time trying to repro this but couldn't just by running a default console app. When you see this issue are you running any other performance collection tools? i.e. dotnet-trace, perfview, VS performance monitor, etc?

This issue has been marked needs-author-action and may be missing some important information.

[karakasa]

When you see this issue are you running any other performance collection tools? i.e. dotnet-trace, perfview, VS performance monitor, etc?

I was running benchmarks through BenchmarkDotNet and out of a sudden all tests using CoreRun started to fail. After that, I tried running a blank ConsoleApp with CoreRun from the terminal and got the assertion failure. I did have Visual Studio opened but I didn't run through it, nor was VS in the debugging mode.

I haven't experienced similar issues in the past 2 weeks so I assume something is wrong in the Windows environment. I would like to close the issue for now. Thank you.