IntrinsicsInSystemPrivateCoreLibAnalyzer throwing ArgumentException

[ericstj]

Description

When building System.Private.CoreLib I see the diagnostic:

error AD0001: Analyzer 'IntrinsicsInSystemPrivateCoreLib.IntrinsicsInSystemPrivateCoreLibAnalyzer' threw an excep
tion of type 'System.ArgumentException' with message 'Syntax node is not within syntax tree'.

I'll suppress this when enabling AD0001 as warning. This issue will track fixing that analyzer and removing the warning suppression.

Reproduction Steps

Remove AD0001 from System.Private.Corelib.csproj and build it.

Expected behavior

Builds without warning.

Actual behavior

Warning as above.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

[sbomer]

I debugged one instance of this - it's failing while trying to decompose the condition

runtime/src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs

Line 1230 in 376e235

if (PackedSpanHelpers.PackedIndexOfIsSupported && PackedSpanHelpers.CanUsePackedIndexOf(c))

The PackedIndexOfIsSupported part goes through this logic:

runtime/src/libraries/System.Private.CoreLib/gen/IntrinsicsInSystemPrivateCoreLibAnalyzer.cs

Lines 290 to 296 in 376e235

	var propertyDefiningSyntax = symbolInfo.Symbol.DeclaringSyntaxReferences[0].GetSyntax();
	if (propertyDefiningSyntax != null)
	{
	if (propertyDefiningSyntax is PropertyDeclarationSyntax propertyDeclaration
	&& propertyDeclaration.ExpressionBody is ArrowExpressionClauseSyntax arrowExpression)
	{
	return DecomposeConditionForIsSupportedGroups(context, model, arrowExpression.Expression);

which looks up the definition of PackedIndexOfIsSupported, which is Sse2.IsSupported. Then we recurse into that property, but this line throws:

runtime/src/libraries/System.Private.CoreLib/gen/IntrinsicsInSystemPrivateCoreLibAnalyzer.cs

Line 275 in 376e235

var symbolInfo = model.GetSymbolInfo(expressionToDecompose);

because the definition of IsSupported isn't in the same syntax tree as the one we started from.

@davidwrighton

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

When building System.Private.CoreLib I see the diagnostic:

error AD0001: Analyzer 'IntrinsicsInSystemPrivateCoreLib.IntrinsicsInSystemPrivateCoreLibAnalyzer' threw an excep
tion of type 'System.ArgumentException' with message 'Syntax node is not within syntax tree'.

I'll suppress this when enabling AD0001 as warning. This issue will track fixing that analyzer and removing the warning suppression.

Reproduction Steps

Remove AD0001 from System.Private.Corelib.csproj and build it.

Expected behavior

Builds without warning.

Actual behavior

Warning as above.

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	ericstj
Assignees:	-
Labels:	area-Infrastructure-coreclr, untriaged, needs-area-label
Milestone:	-