[iOS] XslCompiledTransform tests failing on devices

[steveisok]

#75499 did some house cleaning and did not preserve skipping the entire Xsl suite. XslCompiledTransform is not aot friendly and will result in messages like:

Rolling build link

System.ExecutionEngineException : Attempting to JIT compile method '(wrapper dynamic-method) void object:Execute (System.Xml.Xsl.Runtime.XmlQueryRuntime)' while running in aot-only mode. See https://docs.microsoft.com/xamarin/ios/internals/limitations for more information.


Stack trace
   at System.Delegate.CreateDelegate(Type type, Object firstArgument, MethodInfo method, Boolean throwOnBindFailure, Boolean allowClosed)
   at System.Reflection.Emit.DynamicMethod.CreateDelegate(Type delegateType)
   at System.Xml.Xsl.IlGen.XmlILModule.CreateDelegate(String name, Type typDelegate)
   at System.Xml.Xsl.XmlILGenerator.Generate(QilExpression query, TypeBuilder typeBldr)
   at System.Xml.Xsl.XslCompiledTransform.CompileQilToMsil(XsltSettings settings)
   at System.Xml.Xsl.XslCompiledTransform.LoadInternal(Object stylesheet, XsltSettings settings, XmlResolver stylesheetResolver, XmlResolver originalStylesheetResolver)
   at System.Xml.Xsl.XslCompiledTransform.Load(XmlReader stylesheet, XsltSettings settings, XmlResolver stylesheetResolver)
   at System.Xml.XslCompiledTransformApiTests.Errata4.TestXslTransform(Object param0, Object param1)
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

---

#75499 did some house cleaning and did not preserve skipping the entire Xsl suite. XslCompiledTransform is not aot friendly and will result in messages like:

System.ExecutionEngineException : Attempting to JIT compile method '(wrapper dynamic-method) void object:Execute (System.Xml.Xsl.Runtime.XmlQueryRuntime)' while running in aot-only mode. See https://docs.microsoft.com/xamarin/ios/internals/limitations for more information.


Stack trace
   at System.Delegate.CreateDelegate(Type type, Object firstArgument, MethodInfo method, Boolean throwOnBindFailure, Boolean allowClosed)
   at System.Reflection.Emit.DynamicMethod.CreateDelegate(Type delegateType)
   at System.Xml.Xsl.IlGen.XmlILModule.CreateDelegate(String name, Type typDelegate)
   at System.Xml.Xsl.XmlILGenerator.Generate(QilExpression query, TypeBuilder typeBldr)
   at System.Xml.Xsl.XslCompiledTransform.CompileQilToMsil(XsltSettings settings)
   at System.Xml.Xsl.XslCompiledTransform.LoadInternal(Object stylesheet, XsltSettings settings, XmlResolver stylesheetResolver, XmlResolver originalStylesheetResolver)
   at System.Xml.Xsl.XslCompiledTransform.Load(XmlReader stylesheet, XsltSettings settings, XmlResolver stylesheetResolver)
   at System.Xml.XslCompiledTransformApiTests.Errata4.TestXslTransform(Object param0, Object param1)
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)

Author:	steveisok
Assignees:	-
Labels:	area-System.Xml
Milestone:	-

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

---

#75499 did some house cleaning and did not preserve skipping the entire Xsl suite. XslCompiledTransform is not aot friendly and will result in messages like:

System.ExecutionEngineException : Attempting to JIT compile method '(wrapper dynamic-method) void object:Execute (System.Xml.Xsl.Runtime.XmlQueryRuntime)' while running in aot-only mode. See https://docs.microsoft.com/xamarin/ios/internals/limitations for more information.


Stack trace
   at System.Delegate.CreateDelegate(Type type, Object firstArgument, MethodInfo method, Boolean throwOnBindFailure, Boolean allowClosed)
   at System.Reflection.Emit.DynamicMethod.CreateDelegate(Type delegateType)
   at System.Xml.Xsl.IlGen.XmlILModule.CreateDelegate(String name, Type typDelegate)
   at System.Xml.Xsl.XmlILGenerator.Generate(QilExpression query, TypeBuilder typeBldr)
   at System.Xml.Xsl.XslCompiledTransform.CompileQilToMsil(XsltSettings settings)
   at System.Xml.Xsl.XslCompiledTransform.LoadInternal(Object stylesheet, XsltSettings settings, XmlResolver stylesheetResolver, XmlResolver originalStylesheetResolver)
   at System.Xml.Xsl.XslCompiledTransform.Load(XmlReader stylesheet, XsltSettings settings, XmlResolver stylesheetResolver)
   at System.Xml.XslCompiledTransformApiTests.Errata4.TestXslTransform(Object param0, Object param1)
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, Span`1 args, BindingFlags invokeAttr)

Author:	steveisok
Assignees:	-
Labels:	area-System.Xml, untriaged, os-ios
Milestone:	-

[stephentoub]

Where were these previously being suppressed? e.g. what file contained what directive to cause them to be skipped?

[danmoseley]

That link still says xamarin?

[steveisok]

https://docs.microsoft.com/xamarin/ios/internals/limitations

src/libraries/tests.proj is the place where whole suites can be skipped. tbh, we are catching this in iOS one rolling build after the change went in. That's expected.

runtime/src/libraries/tests.proj

Line 262 in 6e4eacf

<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Private.Xml\tests\Xslt\XslCompiledTransformApi\System.Xml.Xsl.XslCompiledTransformApi.Tests.csproj" />

[jkotas]

The problem exists for NativeAOT too. All Xsl tests require reflection emit.

All of them should be conditionalized on PlatformDetection.IsReflectionEmitSupported .