-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Closed
Labels
Description
I believe there is something wrong with spmi-diff pipeline. Even for PRs that shouldn't have code diffs is showing diffs.
- Pipelines - Run 20220819.5 (azure.com) shows x64 diffs for my change in Use the register of CAST for contained index operator by kunalspathak · Pull Request #74275 · dotnet/runtime (github.com) that was just done under TARGET_ARM64.
- Pipelines - Run 20220819.2 (azure.com) shows diff for a change in that is mostly renaming macros (and hoping that nothing missed out that would trigger the diff)
- And FINALLY, the biggest one Pipelines - Run 20220819.12 (azure.com) shows -16436 code size improvements from Egor Bogatov Improve JitDisasm for top-level statements, expose DumpJittedMethods in Release by EgorBo · Pull Request #74090 · dotnet/runtime (github.com).
I looked into the spmi-diff
for #74090 and the diffs looks unrelated. The following diff is coming from #74110, but is reported in #74090.
Likewise, below diff is unrelated to #74090 as well as #74110.