system.text.regularexpressions.tests work item

[runfoapp]

Build terminating in CI with little indication why on TvOS:
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-03666e5d9e604c64bd/System.Text.RegularExpressions.Tests/1/console.adbd082e.log?%3Fhelixlogtype%3Dresult

  [211/217] xunit.execution.dotnet.dll -> xunit.execution.dotnet.dll.s, xunit.execution.dotnet.dll-llvm.o, xunit.execution.dotnet.aotdata
  [212/217] xunit.runner.utility.netcoreapp10.dll -> xunit.runner.utility.netcoreapp10.dll.s, xunit.runner.utility.netcoreapp10.dll-llvm.o, xunit.runner.utility.netcoreapp10.aotdata
  [213/217] System.Text.RegularExpressions.Tests.dll -> System.Text.RegularExpressions.Tests.dll.s, System.Text.RegularExpressions.Tests.dll-llvm.o, System.Text.RegularExpressions.Tests.aotdata
./xharness-runner.apple.sh: line 173: 16241 Terminated: 15          source command.sh
Removing empty log files:
ls: /tmp/helix/working/AADA097D/w/AF48095E/uploads/xunit-*.xml: No such file or directory
+ exit_code=143

Runfo Tracking Issue: system.text.regularexpressions.tests work item

Build	Definition	Kind	Run Name

Build Result Summary

Day Hit Count	Week Hit Count	Month Hit Count
0	0	0

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Runfo Creating Tracking Issue (data being generated)

Author:	runfoapp[bot]
Assignees:	-
Labels:	area-System.Text.RegularExpressions
Milestone:	-

Tagging subscribers to 'os-tvos': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Build terminating in CI with little indication why on TvOS:
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-03666e5d9e604c64bd/System.Text.RegularExpressions.Tests/1/console.adbd082e.log?%3Fhelixlogtype%3Dresult

  [211/217] xunit.execution.dotnet.dll -> xunit.execution.dotnet.dll.s, xunit.execution.dotnet.dll-llvm.o, xunit.execution.dotnet.aotdata
  [212/217] xunit.runner.utility.netcoreapp10.dll -> xunit.runner.utility.netcoreapp10.dll.s, xunit.runner.utility.netcoreapp10.dll-llvm.o, xunit.runner.utility.netcoreapp10.aotdata
  [213/217] System.Text.RegularExpressions.Tests.dll -> System.Text.RegularExpressions.Tests.dll.s, System.Text.RegularExpressions.Tests.dll-llvm.o, System.Text.RegularExpressions.Tests.aotdata
./xharness-runner.apple.sh: line 173: 16241 Terminated: 15          source command.sh
Removing empty log files:
ls: /tmp/helix/working/AADA097D/w/AF48095E/uploads/xunit-*.xml: No such file or directory
+ exit_code=143

Runfo Tracking Issue: system.text.regularexpressions.tests work item

Build	Definition	Kind	Run Name	Console	Core Dump	Test Results	Run Client
1902387	runtime-extra-platforms	Rolling	net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open	console.log			runclient.py
1902034	runtime-extra-platforms	Rolling	net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125	console.log			runclient.py
1902000	runtime-extra-platforms	PR 72706	net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open	console.log			runclient.py
1902000	runtime-extra-platforms	PR 72706	net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open	console.log			runclient.py
1901961	runtime-extra-platforms	PR 72802	net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open	console.log			runclient.py
1901750	runtime-extra-platforms	PR 72545	net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open	console.log			runclient.py
1901717	runtime-extra-platforms	PR 72554	net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open	console.log			runclient.py
1901444	runtime-extra-platforms	PR 72707	net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open	console.log			runclient.py
1901068	runtime-extra-platforms	Rolling	net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open	console.log			runclient.py
1900887	runtime-extra-platforms	Rolling	net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125	console.log			runclient.py
1900783	runtime-extra-platforms	PR 67861	net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open	console.log			runclient.py
1900774	runtime-extra-platforms	PR 72545	net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open	console.log			runclient.py
1900774	runtime-extra-platforms	PR 72545	net7.0-MacCatalyst-Release-arm64-Mono_Release-OSX.1200.Arm64.Open	console.log			runclient.py
1900571	runtime-extra-platforms	Rolling	net7.0-tvOS-Release-arm64-Mono_Release-OSX.1100.Amd64.AppleTV.Open	console.log			runclient.py
1900480	runtime-extra-platforms	Rolling	net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125	console.log			runclient.py
1900064	runtime-extra-platforms	Rolling	net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125	console.log			runclient.py
1899653	runtime-extra-platforms	Rolling	net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125	console.log			runclient.py
1899117	runtime-extra-platforms	Rolling	net7.0-Linux-Release-x64-CoreCLR_release-(Fedora.34.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-34-helix-20220523150939-4f64125	console.log			runclient.py

Build Result Summary

Day Hit Count	Week Hit Count	Month Hit Count
8	16	16

Author:	runfoapp[bot]
Assignees:	-
Labels:	area-System.Text.RegularExpressions, blocking-clean-ci, untriaged, os-tvos
Milestone:	-

[noahfalk]

This may be the same build issue as: #72836

[steveisok]

The issue is the test suite untrimmed will generate an app size around 1GB. For whatever reason, the helix machines churn when trying to build it and end up timing out. The solution I think will work is to bring over the aggressive trimming test targets that exist in

runtime/eng/testing/tests.mobile.targets

Lines 179 to 217 in 73374e8

	<Target Name="ConfigureTrimming" Condition="('$(EnableAggressiveTrimming)' == 'true' or '$(EnableSoftTrimming)' == 'true') And '$(SkipConfigureTrimming)' != 'true'" AfterTargets="AddTestRunnersToPublishedFiles">
	<PropertyGroup>
	<TrimMode Condition="'$(EnableAggressiveTrimming)' == 'true'">link</TrimMode>
	<TrimMode Condition="'$(EnableSoftTrimming)' == 'true'">copyused</TrimMode>
	</PropertyGroup>
	<ItemGroup>
	<!-- Mark all the assemblies for link. We will explicitly mark the non-trimmable ones -->
	<ResolvedFileToPublish TrimMode="$(TrimMode)" />
	<!-- Don't trim the main assembly.
	TrimMode="" is needed so the root assemblies are correctly identified -->
	<ResolvedFileToPublish TrimMode="" Condition="'%(FileName)' == '$(AssemblyName)'" />
	<!-- TODO: find out why these assemblies aren't copied by copyused even though they're referenced -->
	<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.ComponentModel.EventBasedAsync'" />
	<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Diagnostics.FileVersionInfo'" />
	<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Drawing.Primitives'" />
	<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.IO.Pipelines'" />
	<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Memory'" />
	<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Net.WebHeaderCollection'" />
	<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Runtime.Serialization.Formatters'" />
	<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Security.AccessControl'" />
	<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Security.Claims'" />
	<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Security.Permissions'" />
	<ResolvedFileToPublish TrimMode="Copy" Condition="'$(EnableSoftTrimming)' == 'true' and '%(FileName)' == 'System.Transactions.Local'" />
	<!-- Even though we are trimming the test runner assembly, we want it to be treated
	as a root -->
	<TrimmerRootAssembly
	Condition="$([System.String]::Copy('%(ResolvedFileToPublish.FileName)%(ResolvedFileToPublish.Extension)').EndsWith('TestRunner.dll'))"
	Include="%(ResolvedFileToPublish.FullPath)" />
	</ItemGroup>
	<ItemGroup>
	<TrimmerRootDescriptor Include="$(MSBuildThisFileDirectory)ILLink.Descriptor.xunit.xml" Condition="'$(SkipXunitTrimmerDescriptor)' != 'true'" />
	<TrimmerRootDescriptor Include="$(MSBuildThisFileDirectory)ILLink.Descriptor.TestUtilities.xml" Condition="'$(SkipTestUtilitiesReference)' != 'true'" />
	</ItemGroup>
	</Target>

That will bring the app size down to about 300MB, which the helix machines should be able to handle without much trouble. Until the targets and xml descriptor files are sent over, the tests should be skipped.