Pipeline dependency issue: Artifact CoreCLRProduct bits missing.

[hoyosjs]

We have builds failing to acquire the CoreCLR runtime bits. I am not sure why these are needed for the mono bits there. @directhex or @akoeplinger any idea there? For example https://dev.azure.com/dnceng/public/_build/results?buildId=1170249&view=logs&j=a3584aa7-f6a0-5e90-05ca-4edce1db7c76&t=6251704e-67a1-5275-71bd-ce7ee4c63087

This is likely caused by #53696 as product dependencies have been removed from the shared test build and this had an implicit dependency edge. We can get this working by adding the dependency explicitly if needed, or removing the download if not necessary.

cc: @dotnet/runtime-infrastructure

Runfo Tracking Issue: Pipeline dependency issue: Artifact CoreCLRProduct bits missing.

Definition	Build	Kind	Job Name
runtime	1178491	PR 53920	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1178491	PR 53920	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1177036	Rolling	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1177036	Rolling	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1176617	PR 53439	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1176617	PR 53439	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1176566	PR 52866	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1176566	PR 52866	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1176412	PR 53698	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1176412	PR 53698	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1176339	PR 53866	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1176091	Rolling	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1176091	Rolling	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1176063	PR 53669	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1176063	PR 53669	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1175897	Rolling	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1175897	Rolling	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1175285	PR 53836	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1175285	PR 53836	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1175261	PR 53763	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1175261	PR 53763	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1174593	PR 53606	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1174593	PR 53606	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1174517	Rolling	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1174291	PR 53806	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1174264	PR 52791	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1174264	PR 52791	Mono minijit Pri0 Runtime Tests Run OSX x64 release
runtime	1174155	Rolling	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1174093	PR 53656	Mono monointerpreter Pri0 Runtime Tests Run OSX x64 release
runtime	1174093	PR 53656	Mono minijit Pri0 Runtime Tests Run OSX x64 release

Build Result Summary

Day Hit Count	Week Hit Count	Month Hit Count
2	17	17

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

We have builds failing to acquire the CoreCLR runtime bits. I am not sure why these are needed for the mono bits there. @directhex or @akoeplinger any idea there? For example https://dev.azure.com/dnceng/public/_build/results?buildId=1170249&view=logs&j=a3584aa7-f6a0-5e90-05ca-4edce1db7c76&t=6251704e-67a1-5275-71bd-ce7ee4c63087

This is likely caused by #53696 as product dependencies have been removed from the shared test build and this had an implicit dependency edge. We can get this working by adding the dependency explicitly if needed, or removing the download if not necessary.

cc: @dotnet/runtime-infrastructure

Author:	hoyosjs
Assignees:	-
Labels:	area-Infrastructure
Milestone:	-

[hoyosjs]

Is CoreCLR's product build needed to build the coreroot on mono's builds?

[SingleAccretion]

Is CoreCLR's product build needed to build the coreroot on mono's builds?

I believe so, see also #53421.

[hoyosjs]

So yes, based on the last comment this is bad.

[akoeplinger]

If someone knows how to add the dependency in the .yml please feel free to do it :)

[directhex]

https://github.com/dotnet/runtime/blob/d617e830ec621db80f6df9ed8ba75176f5ba6035/eng/pipelines/runtime.yml#L596-603 is how you do dependence

…

Sent from my iPhone

On Jun 10, 2021, at 8:43 AM, Alexander Köplinger ***@***.***> wrote:  If someone knows how to add the dependency in the .yml please feel free to do it :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[safern]

This is a known issue that came out during the surge and that @naricc was working on. #43952

It seems like he has not gotten cycles to fix it.

the short term fix should be make sure we are getting the right dependency always for mono against coreclr here:

runtime/eng/pipelines/common/templates/runtimes/run-test-job.yml

Line 66 in 43b1f2c

- ${{ if or( eq(parameters.runtimeVariant, 'minijit'), eq(parameters.runtimeVariant, 'monointerpreter')) }}: