CultureData initialization brings a lot of dependencies

[marek-safar]

CultureData initialization brings a lot of dependencies for members which are rarely used. Few examples are _SpecificCulture and _bNeutral but there are more.

It'd decrease the size of a trimmed app if we moved all these data into delayed initialization. It'd also help with code readability as today it's a mix of random jumps that can interfere with each other and are hard to follow.

Tagging subscribers to this area: @tarekgh, @safern, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

---

CultureData initialization brings a lot of dependencies for members which are rarely used. Few examples are _SpecificCulture and _bNeutral but there are more.

It'd decrease the size of a trimmed app if we moved all these data into delayed initialization. It'd also help with code readability as today it's a mix of random jumps that can interfere with each other and are hard to follow.

Author:	marek-safar
Assignees:	-
Labels:	area-System.Globalization, untriaged
Milestone:	-

[tarekgh]

@marek-safar could you point at _bNeutral data you are referring to?

I understand the benefit of that but I sated to worry the maintenance of the code started to be very complicated. so we need to weigh that against the benefit.

[marek-safar]

could you point at _bNeutral data you are referring to?

runtime/src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs

Line 1237 in 496bc88

internal string TwoLetterISOCountryName => _sISO3166CountryName ??= GetLocaleInfoCore(LocaleStringData.Iso3166CountryName);

worry the maintenance of the code started to be very complicated

I think the changes could actually lead to clearer/simple code

[tarekgh]

@marek-safar You are not pointing at _bNeutral at all. would be good to fix the description of the issue.

[marek-safar]

What do you mean? The link in the description points to a line where _bNeutral is set and when you asked for data I added another comment point to value _bNeutral is set with.

[tarekgh]

Maybe I am missing something here. the line initialize _bNeutral is

runtime/src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs

Line 789 in 496bc88

cd._sName = NormalizeCultureName(cultureName, out cd._bNeutral);

which is not really using any data. the link you sent is pointing at

internal string TwoLetterISOCountryName => _sISO3166CountryName ??= GetLocaleInfoCore(LocaleStringData.Iso3166CountryName); 

which I have no idea how this is related to _bNeutral.

[marek-safar]

Your code is I believe for invariant mode only, if you click on the link in the description it should take you to

runtime/src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Unix.cs

Line 68 in 6072e4d

_bNeutral = TwoLetterISOCountryName.Length == 0;