Build for System.Runtime fails within VS

[danmoseley]

Cleaned and synced to today

build.cmd clr+libs -rc release
build.cmd -subset libs.tests -rc release
build.cmd -subset libs.tests -framework net48 -rc release
build -vs System.Runtime

Build in VS and it fails with

7>C:\git\runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(195,5): error MSB4018: The "GenerateDepsFile" task failed unexpectedly.
7>C:\git\runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(195,5): error MSB4018: System.NullReferenceException: Object reference not set to an instance of an object.
7>C:\git\runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(195,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ReferenceInfo.GetVersion(ITaskItem referencePath)
7>C:\git\runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(195,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ReferenceInfo.CreateReferenceInfo(ITaskItem referencePath)
7>C:\git\runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(195,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ReferenceInfo.CreateReferenceInfos(IEnumerable`1 referencePaths)
7>C:\git\runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(195,5): error MSB4018:    at Microsoft.NET.Build.Tasks.GenerateDepsFile.WriteDepsFile(String depsFilePath)
7>C:\git\runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(195,5): error MSB4018:    at Microsoft.NET.Build.Tasks.GenerateDepsFile.ExecuteCore()
7>C:\git\runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(195,5): error MSB4018:    at Microsoft.NET.Build.Tasks.TaskBase.Execute()
7>C:\git\runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(195,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
7>C:\git\runtime\.dotnet\sdk\5.0.100-preview.8.20362.3\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(195,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()
7>Done building project "System.Runtime.Tests.csproj" -- FAILED.

I have a design time binlog available.

Reproes with both VS 16.8.0 and 16.6.5.

From the binlog we know it's when VS is trying to build with TF=Unix.

@ericstj any thoughts? @ViktorHofer and @safern are puzzled.

[Dotnet-GitSync-Bot]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

[ericstj]

Sorry I was late to this issue. Is it still reproducing? Can you share your binlog? Looking at the code that is NRE, it looks to me like it might happen when FusionName metadata exists but is missing version part. https://github.com/dotnet/sdk/blob/a5f5bb5183517cb301050288b25c9c727e52e8a6/src/Tasks/Microsoft.NET.Build.Tasks/ReferenceInfo.cs#L150

[danmoseley]

I'll try it.

[danmoseley]

Yes still repros with latest sources. Shared binlog by email @ericstj

[danmoseley]

This is the only item missing a FusionName version:

8>                        C:\git\runtime\artifacts\bin\System.Security.Principal.Windows\net5.0-Unix-Debug\System.Security.Principal.Windows.dll
8>                                BuildReference=true
8>                                CopyLocal=false
8>                                CopyUpToDateMarker=C:\git\runtime\artifacts\obj\System.Security.Principal.Windows\net5.0-Unix-Debug\System.Security.Principal.Windows.csproj.CopyComplete
8>                                FusionName=System.Security.Principal.Windows
8>                                HasSingleTargetFramework=true
8>                                IsRidAgnostic=true
8>                                MSBuildSourceProjectFile=C:\git\runtime\src\libraries\System.Security.Principal.Windows\src\System.Security.Principal.Windows.csproj
8>                                MSBuildSourceTargetName=GetTargetFrameworks
8>                                NuGetPackageId=System.Security.Principal.Windows
8>                                NuGetPackageVersion=6.0.0
8>                                OriginalItemSpec=C:\git\runtime\artifacts\bin\System.Security.Principal.Windows\net5.0-Unix-Debug\System.Security.Principal.Windows.dll
8>                                OriginalProjectReferenceItemSpec=C:\git\runtime\src\libraries\System.Security.Principal.Windows\src\System.Security.Principal.Windows.csproj
8>                                OutputItemType=
8>                                Private=false
8>                                PrivateAssets=all
8>                                ProjectReferenceOriginalItemSpec=C:\git\runtime\src\libraries\System.Security.Principal.Windows\src\System.Security.Principal.Windows.csproj
8>                                ReferenceAssembly=C:\git\runtime\artifacts\bin\ref\net5.0\System.Security.Principal.Windows.dll
8>                                ReferenceOutputAssembly=true
8>                                ReferenceSourceTarget=ProjectReference
8>                                ResolvedFrom=
8>                                SetTargetFramework=TargetFramework=net5.0-Unix
8>                                SkipGetTargetFrameworkProperties=true
8>                                TargetFrameworkIdentifier=.NETCoreApp
8>                                TargetFrameworks=net5.0-Windows_NT;net5.0-Unix;netstandard2.0;netcoreapp2.0-Windows_NT;netcoreapp2.0-Unix;netcoreapp2.1-Windows_NT;netcoreapp2.1-Unix;net461-Windows_NT
8>                                TargetFrameworkVersion=5.0
8>                                TargetPlatformIdentifier=
8>                                TargetPlatformMoniker=,Version=
8>                                Targets=
8>                                Version=

Note it says net5.0-Unix -- it's the only reference that has TargetFramework=net5.0-Unix

[danmoseley]

@Anipik any idea what might be going on? As far as I can see, building the sln tries to build System.Runtime.Tests in all its configurations, which includes net50-Unix-Debug. System.Security.Principal.Windows has net50-Windows_NT and net50_Unix target frameworks - the latter being a PNSE assembly.

[Anipik]

Nothing that stands out, but i can debug the issue next week

[Anipik]

The issue here is that we have just buid net5.0-windows from the root and trying to build the tests for net5.0-unix as well from the vs.
When we build from the vs, it doesn't build all the project references and expects that these are already built.
Doing a build on tests

1>------ Build started: Project: System.Runtime (ref\System.Runtime), Configuration: Debug Any CPU ------
2>------ Build started: Project: TestUtilities, Configuration: Debug Any CPU ------
3>------ Build started: Project: TestUtilities.Unicode, Configuration: Debug Any CPU ------
1>System.Runtime -> C:\git\runtime\artifacts\bin\System.Runtime\ref\net5.0-Debug\System.Runtime.dll
4>------ Build started: Project: System.Runtime (src\System.Runtime), Configuration: Debug Any CPU ------
2>TestUtilities -> C:\git\runtime\artifacts\bin\TestUtilities\net461-Debug\TestUtilities.dll
3>TestUtilities.Unicode -> C:\git\runtime\artifacts\bin\TestUtilities.Unicode\net5.0-Debug\TestUtilities.Unicode.dll
4>System.Runtime -> C:\git\runtime\artifacts\bin\System.Runtime\net5.0-Debug\System.Runtime.dll
5>------ Build started: Project: TestCollectibleAssembly, Configuration: Debug Any CPU ------
6>------ Build started: Project: TestLoadAssembly, Configuration: Debug Any CPU ------
6>TestLoadAssembly -> C:\git\runtime\artifacts\bin\TestLoadAssembly\netstandard2.0-Debug\TestLoadAssembly.dll
5>TestCollectibleAssembly -> C:\git\runtime\artifacts\bin\TestCollectibleAssembly\netstandard2.0-Debug\TestCollectibleAssembly.dll
2>TestUtilities -> C:\git\runtime\artifacts\bin\TestUtilities\net5.0-Debug\TestUtilities.dll
7>------ Build started: Project: System.Runtime.Tests, Configuration: Debug Any CPU ------
8>------ Build started: Project: System.Runtime.Nls.Tests, Configuration: Debug Any CPU ------
8>System.Runtime.Nls.Tests -> C:\git\runtime\artifacts\bin\System.Runtime.Nls.Tests\net5.0-Windows_NT-Debug\System.Runtime.Nls.Tests.dll
7>System.Runtime.Tests -> C:\git\runtime\artifacts\bin\System.Runtime.Tests\net5.0-Browser-Debug\System.Runtime.Tests.dll
7>System.Runtime.Tests -> C:\git\runtime\artifacts\bin\System.Runtime.Tests\net5.0-Unix-Debug\System.Runtime.Tests.dll
7>System.Runtime.Tests -> C:\git\runtime\artifacts\bin\System.Runtime.Tests\net5.0-Windows_NT-Debug\System.Runtime.Tests.dll
========== Build: 8 succeeded, 0 failed, 2 up-to-date, 0 skipped ==========

i will try Adding all the project dependencies to the sln.