Unify CoreLib/System.Runtime.Numerics formatting/parsing code

[stephentoub]

Once upon a time it seems as though System.Runtime.Numerics forked the integer formatting/parsing code that's in CoreLib. That CoreLib code has since evolved, and is also now being mirrored to corefx, where System.Runtime.Numerics could include it rather than maintaining its own copy.

cc: @tannergooding

[nabeelvalley]

Hi, is this still open? What's needed on this?

[stephentoub]

is this still open?

Yes

What's needed on this?

The file
https://github.com/dotnet/corefx/blob/master/src/Common/src/System/Globalization/FormatProvider.Number.cs
is now a stale copy of https://github.com/dotnet/corefx/blob/master/src/Common/src/CoreLib/System/Number.Formatting.cs
though there's likely some functionality in the former that no longer exists in the latter but that's still needed for BigInteger.

The work here is to rationalize the difference and get to a point where the System.Runtime.Numerics library (which is currently including the former) can instead include the latter, and do so without negatively impacting the performance of code currently using the latter.

[danmoseley]

@nabeelvalley want to take a shot at this work?

[nabeelvalley]

@danmosemsft / @stephentoub I'd like to look at it, still a little unclear about what exactly is needed though, and also what background knowledge/info would I need to work on this?

[danmoseley]

@nabeelvalley its pretty much what's described above. You could take a look at the code mentioned maybe.

For a first contribution though, you could look at a smaller change if you want to ? There are a lot of issues marked "up for grabs" you could choose from.

[nabeelvalley]

Hi @danmosemsft , thanks, I've taken a look and it seems a bit out of my depth at the moment, but I will look at what else is around

[danmoseley]

@nabeelvalley ok, not a problem, hope to see you elsewhere in the repo!

Tagging subscribers to this area: @tannergooding
Notify danmosemsft if you want to be subscribed.