build.cmd clr -msbuild fails

[saucecontrol]

After pulling latest main, I can no longer build clr with -msbuild

build clr -c checked -msbuild

Error:

  C:\git\runtime\src\coreclr\vm\amd64\CachedInterfaceDispatchCoreCLR.asm(1): fatal error A1000: cannot open file :
   cee_wks_core.dir\Checked\/__/amd64/CachedInterfaceDispatchCoreCLR.asm.obj [C:\git\runtime\artifacts\obj\coreclr
  \windows.x64.Checked\ide\vm\wks\cee_wks_core.vcxproj]

Looks like the file in question was added in #111771, but I don't immediately see what the problem is.

Ninja build succeeds.

Build with -msbuild succeeds on 28facae, which is the commit immediately before #111771 was merged.

If it matters:
cmake version 3.30.5-msvc23
Microsoft Visual Studio Community 2022 (64-bit) - Preview
Version 17.14.0 Preview 2.0

[dotnet-policy-service]

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

[jkotas]

cc @davidwrighton

[shunkino]

I also have encountered this issue and was able to work around it by modifying file name as in:
cbec067. I'm totally new to build system of this repo, so it might be wrong but following is my findings.

When vcxproj is generated by msbuild option, it will have ObjectFileName definition like this:

<!-- Z:\artifacts\obj\coreclr\windows.x64.Debug\ide\nativeaot\Runtime\Full\Runtime.WorkstationGC.vcxproj -->
    <ClCompile Include="Z:\src\coreclr\nativeaot\Runtime\CachedInterfaceDispatchAot.cpp">
      <ObjectFileName>$(IntDir)/__/CachedInterfaceDispatchAot.cpp.obj</ObjectFileName>
    </ClCompile>
...
    <MASM Include="Z:\src\coreclr\nativeaot\Runtime\amd64\CachedInterfaceDispatchAot.asm">
      <ObjectFileName>$(IntDir)/__/amd64/CachedInterfaceDispatchAot.asm.obj</ObjectFileName>
    </MASM>

This is causing problem because $(IntDir) cotains Windows-style directory path ending with backslash () and generates invalid file path like Runtime.WorkstationGC.dir\Debug\/__/amd64/CachedInterfaceDispatchAot.asm.obj, which has mixing backslash and slash, as the result.

    <IntDir Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">Runtime.WorkstationGC.dir\Debug\</IntDir>

These behaviors seems to be caused by combination of CMake's default behavior when there are files with same name except file extensions added in CMakeLists.txt and convert_to_absolute_path function. So, possible fix will be to:
A. Rename files to avoid ObjectFileName section to be generated
B. Change options for CMake or implementation of convert_to_absolute_path to avoid invalid file path generation

I implemented option A in my PoC commit because it seems simpler and easier. Can you validate if my approach is correct? I can also write PR if this is the safe way to go.