Suspicious code fragments in System.Text.Json

[rip-mm]

Description

Hello.

I have checked project using the PVS-Studio analyzer. The results of the check revealed a number of suspicious code fragments that I have included in an article. You may be interested in taking a look at them.

It's worth noting that the article contains only the most interesting warnings issued by the analyzer. You can check your project in more detail using the free version of PVS-Studio for open-source projects.

Reproduction Steps

Not required

Expected behavior

Not required

Actual behavior

Not required

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

[huoyaoyuan]

Thank you for help to diagnose the code quality of runtime repository. The linked article is somehow verbose to read, and it doesn't contain links to the source code that we can identify quickly.

The analyzer reports are valid. Some are already fixed (#112090) by inspiration of your article. Some issues are in the test/debug suite which are less severe.

You are welcomed to submit pull requests to fix the issues. Please submit to main branch and we will backport real important fixes to existing releases.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

[dotnet-policy-service]

This issue has been marked needs-author-action and may be missing some important information.

[jkotas]

#112384 is fixing issues mentioned in the article that has not been fixed yet, except the ones in System.Text.Json.

@dotnet/area-system-text-json Please take a look at the issues in System.Text.Json