Closed
Description
This is a summary of TODO|FIXME|NotImplementedEx
in src/native/managed/cdacreader:
- In
CodeVersions_1
:IsActiveNativeCodeVersion
needs to handle theNativeCodeVersionHandle::CodeVersionNodeAddress
non-null case - by reading theNativeCodeVersionNode
data and checking theIsActive
fieldFindActiveNativeCodeVersion
needs to handle the!IsActiveNativeCodeVersion(node)
case by iterating over the versioning state nodesFindActiveNativeCodeVersion
needs to handle theILCodeVersionHandle::ILCodeVersionNode
non-null case by examining the explicit IL code version- [cdac] Handle non-default active version and explicit IL code version cases for
CodeVersions.GetActiveNativeCodeVersion
#109560
- In
ExecutionManager_1
:- (big)
ReadyToRunJitManager::GetMethodInfo
needs to be implemented followingReadyToRunJitManager::JitCodeToMethodInfo
in the C++ code.
- (big)
- In
RuntimeTypeSystem_1
:- In
GetAddressOfSlot
handle theslotNum > mt.NumVirtuals
case of non-virtual slots allocated in front ofMethodTableAuxiliaryData
- In
GetLoaderModule
handle type descs followingTypeDesc::GetLoaderModule
from the C++ code - In
GetMethodClassificationDataType
get the sizes for many non-IL method descriptors (FCall, PInvoke, EEImpl, ArrayMethod, ComInterp)- For
GetMethodClassificationDataType
verify thatdatadescriptor.h
has definite sizes for all the MethodDesc subkinds - [cdac] Handle non-IL method descs in
RuntimeTypeSystem_1.GetMethodClassificationDataType
#110602
- For
- [cdac] Handle no method def token when trying to get the IL version state #110449
- [cdac] Fix calculation of
MethodDesc
optional slot addresses #110491
- In
- In
SOSDacImpl::GetMethodDescData
:- [cDAC] Implement ReJIT portion of SOSDacImpl::GetMethodDescData #109936 ReJIT Support
- Handle filling out
DacpMethodDescData
fields around re-JIT:rejitDataCurrent
,rejitDataRequested
,cJittedReJitVersions
rejitDataCurrent
andrejitDataRequested
will require adding to theCodeVersion
contract to get the version ID and re-JIT state for aNativeCodeVersionHandle
cJittedReJitVersions
will require adding to theCodeVersion
contract to get all re-JIT versions instead of just active
- Handle the
cRevertedRejitVersions != 0
requests - Handle the
pcNeededRevertedRejitData != null
requests
- Handle filling out
- [cDAC] Implement GCCover portion of SOSDacImpl::GetMethodDescData #110322
- Handle the
HAVE_GCCOVER
case and implement aGetGCCoverageInfo
method for theNativeCode
contract
- Handle the
- Handle the
bIsDynamic
case [cDAC] SOSDacImpl::GetMethodDescData DynamicMethodObject #110545- Remove throw without implemented
managedDynamicMethodObject
- Remove throw without implemented
- [cDAC] Implement ReJIT portion of SOSDacImpl::GetMethodDescData #109936 ReJIT Support
- In
RuntimeTypeSystem_1
andMethodValidation
: there are many// TODO(cdac): _ASSERTE (...)
comments that include assertions that the C++ code had in the corresponding code. Implement them asDebug.Assert()
or drop them.