Skip to content

Q: System.Diagnostics.Activity out of proc monitoring value conversion culture variance #102896

Open

Description

We can use DiagnosticSourceEventSource to listen to Activity \ traces out of proc. One of the things it does is normalize all tags (KeyValuePair<string, object?>) into strings (KeyValuePair<string, string?>).

Code:

return new KeyValuePair<string, string?>(_outputName, obj?.ToString());

Question: Should we use InvariantCulture when we do this?

Probably also the same question\issue for metrics and logs.

/cc @tarekgh @noahfalk @samsp-msft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions