Does any one know why AddSingleton and TryAddSingleton/TryAddKeyedSingleton dont have same overloads?

[zarlo]

does any one know what there is not a TryAddX version of this overload with both Type params like

  public static IServiceCollection AddSingleton<TService, TImplementation>(
    this IServiceCollection services,
    Func<IServiceProvider, TImplementation> implementationFactory)
    where TService : class
    where TImplementation : class, TService

the only overloads it has with implementation factories are

  public static void TryAddSingleton(
    this IServiceCollection collection,
    Type service,
    Func<IServiceProvider, object> implementationFactory)

  public static void TryAddSingleton<TService>(
    this IServiceCollection services,
    Func<IServiceProvider, TService> implementationFactory)
    where TService : class

[pumpkin-bit]

It seems like Microsoft assumes that if you're using this, you're already smart enough to write the extension yourself ;)
But seriously, it's probably because it's trivial to write an extension method yourself, so it's a low priority unfortunately, this is an oversight in the API itself that causes some inconvenience...

I've attached an example of an extension you can write, but I think it's just a workaround:

public static void TryAddSingleton<TService, TImplementation>(
    this IServiceCollection services,
    Func<IServiceProvider, TImplementation> factory)
    where TService : class
    where TImplementation : class, TService
{
    services.TryAddSingleton<TService>(factory);
}

[zarlo]

i ended up just adding this to my project

    public static IServiceCollection TryAddSingleton<TService, TImplementation>(
        this IServiceCollection services,
        Func<IServiceProvider, TImplementation> implementationFactory)
        where TService : class
        where TImplementation : class, TService
    {
        ArgumentNullException.ThrowIfNull((object) services, nameof (services));
        ArgumentNullException.ThrowIfNull((object) implementationFactory, nameof (implementationFactory));
        var descriptor = ServiceDescriptor.Singleton<TService, TImplementation>(implementationFactory);
        services.TryAdd(descriptor);
        return services;
    }
    
    public static IServiceCollection TryAddTransient<TService, TImplementation>(
        this IServiceCollection services,
        Func<IServiceProvider, TImplementation> implementationFactory)
        where TService : class
        where TImplementation : class, TService
    {
        ArgumentNullException.ThrowIfNull((object) services, nameof (services));
        ArgumentNullException.ThrowIfNull((object) implementationFactory, nameof (implementationFactory));
        var descriptor = ServiceDescriptor.Transient<TService, TImplementation>((Func<IServiceProvider, TImplementation>) implementationFactory);
        services.TryAdd(descriptor);
        return services;
    }
    
    public static IServiceCollection TryAddScoped<TService, TImplementation>(
        this IServiceCollection services,
        Func<IServiceProvider, TImplementation> implementationFactory)
        where TService : class
        where TImplementation : class, TService
    {
        ArgumentNullException.ThrowIfNull((object) services, nameof (services));
        ArgumentNullException.ThrowIfNull((object) implementationFactory, nameof (implementationFactory));
        var descriptor = ServiceDescriptor.Scoped<TService, TImplementation>((Func<IServiceProvider, TImplementation>) implementationFactory);
        services.TryAdd(descriptor);
        return services;
    }
    
    public static IServiceCollection TryAddKeyedSingleton<TService, TImplementation>(
        this IServiceCollection services,
        object? serviceKey,
        Func<IServiceProvider, object, TImplementation> implementationFactory)
        where TService : class
        where TImplementation : class, TService
    {
        ArgumentNullException.ThrowIfNull((object) services, nameof (services));
        ArgumentNullException.ThrowIfNull((object) implementationFactory, nameof (implementationFactory));
        var descriptor = ServiceDescriptor.KeyedSingleton<TService, TImplementation>(serviceKey, implementationFactory);
        services.TryAdd(descriptor);
        return services;
    }
    
    public static IServiceCollection TryAddKeyedTransient<TService, TImplementation>(
        this IServiceCollection services,
        object? serviceKey,
        Func<IServiceProvider, object, TImplementation> implementationFactory)
        where TService : class
        where TImplementation : class, TService
    {
        ArgumentNullException.ThrowIfNull((object) services, nameof (services));
        ArgumentNullException.ThrowIfNull((object) implementationFactory, nameof (implementationFactory));
        var descriptor = ServiceDescriptor.KeyedTransient<TService, TImplementation>(serviceKey, (Func<IServiceProvider, object, TImplementation>) implementationFactory);
        services.TryAdd(descriptor);
        return services;
    }
    
    public static IServiceCollection TryAddKeyedScoped<TService, TImplementation>(
        this IServiceCollection services,
        object? serviceKey,
        Func<IServiceProvider, object, TImplementation> implementationFactory)
        where TService : class
        where TImplementation : class, TService
    {
        ArgumentNullException.ThrowIfNull((object) services, nameof (services));
        ArgumentNullException.ThrowIfNull((object) implementationFactory, nameof (implementationFactory));
        var descriptor = ServiceDescriptor.KeyedScoped<TService, TImplementation>(serviceKey, (Func<IServiceProvider, object, TImplementation>) implementationFactory);
        services.TryAdd(descriptor);
        return services;
    }

[pumpkin-bit]

Yes, your approach seems to address this issue more thoroughly.

I don't think Microsoft will fix this on their own unless someone reports it to them, even if it's causing some inconvenience to the community right now... so there's no harm in using workarounds for now.