Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e78ee77456
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 040cbe2769
Choose a head ref
  • 7 commits
  • 89 files changed
  • 6 contributors

Commits on Dec 17, 2024

  1. Fix ambiguous call build break in Fuzzing project (#110761)

    @MihaZupan
    MihaZupan authored Dec 17, 2024
    Configuration menu
    Copy the full SHA
    9482c1e View commit details
    Browse the repository at this point in the history

  2. Fix native aot outerloop (#110768) 

    This time I broke it. Do not attempt to generate source link data if we're not generating debug information. Debug information is not in a usable state within the compiler.
    @MichalStrehovsky
    MichalStrehovsky authored Dec 17, 2024
    Configuration menu
    Copy the full SHA
    917d290 View commit details
    Browse the repository at this point in the history

  3. [wasm] Fix rebuild of browser-bench with startup apps (#110776) 

    This fixes 2 issues

 * clean build of browser-bench with startup apps failed, because
   WBT's dotnet-latest wasn't available when setting the sdk spath
 * problem with rebuilding WBT, where WBT fails with

```
runtime/src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error MSB4018: The "InstallWorkloadFromArtifacts" task failed unexpectedly. [runtime/src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj] [runtime/src/mono/sample/wasm/browser-bench/Wasm.Browser.Bench.Sample.csproj]
runtime/src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error MSB4018: System.IO.IOException: Directory not empty : 'runtime/artifacts/bin/dotnet-latest/host/fxr/10.0.0-alpha.1.24610.2' [runtime/src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj] [runtime/src/mono/sample/wasm/browser-bench/Wasm.Browser.Bench.Sample.csproj]
runtime/src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error MSB4018: at System.IO.FileSystem.RemoveDirectoryRecursive(String fullPath) [runtime/src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj] [runtime/src/mono/sample/wasm/browser-bench/Wasm.Browser.Bench.Sample.csproj]
runtime/src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error MSB4018: at Microsoft.Workload.Build.Tasks.InstallWorkloadFromArtifacts.Execute() [runtime/src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj] [runtime/src/mono/sample/wasm/browser-bench/Wasm.Browser.Bench.Sample.csproj]
runtime/src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Execute() [runtime/src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj] [runtime/src/mono/sample/wasm/browser-bench/Wasm.Browser.Bench.Sample.csproj]
runtime/src/mono/nuget/Microsoft.NET.Runtime.WorkloadTesting.Internal/Sdk/WorkloadTesting.Core.targets(201,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [runtime/src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj] [runtime/src/mono/sample/wasm/browser-bench/Wasm.Browser.Bench.Sample.csproj]
      0 Warning(s)
      1 Error(s)

```
    @radekdoulik
    radekdoulik authored Dec 17, 2024
    Configuration menu
    Copy the full SHA
    6e894a8 View commit details
    Browse the repository at this point in the history

  4. Re-enable bundle archive building in source build (#110448) 

    Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
    @jkoritzinsky @ViktorHofer
    jkoritzinsky and ViktorHofer authored Dec 17, 2024
    Configuration menu
    Copy the full SHA
    ce9dd2a View commit details
    Browse the repository at this point in the history

  5. [browser] Remove WASM HybridGlobalization from runtime code (#110567) 

    * Removal of `HybridGlobalization` code from the runtime and libs.

* Remove `HybridGlobalization` flag and clean the tests from it.

* Fix build.

* Fix build, remove unused leftovers.

* Fix linker tests.

* Fix the CI error, revert "icudt_hybrid.dat" removal.

* Fix WBT that expected `icudt_hybrid.dat` to be missing.
    @ilonatommy
    ilonatommy authored Dec 17, 2024
    Configuration menu
    Copy the full SHA
    8a25506 View commit details
    Browse the repository at this point in the history

  6. Fix base type marking for DAM annotated classes (#110655) 

    Fixes #104740, also implements #110563 for ILC.

The annotation on DAM annotated classes gets triggered by calling GetType on a location typed as something DAM annotated (or deriving/implementing from it).

The marking is done in layers so that warning suppressions can be properly applied. The bug was that we didn't walk down the hierarchy and assumed someone else will do it. Nobody did. I'm adding a new node type to do the marking.

Previously, we only used one node for tracking. The node got dropped into the dependency graph when we saw GetType being called and it ensured the proper marking for that one type (not the bases). We also added conditional dependencies into MethodTables so that `Derived` can depend on this node of the `Base`. This ensured that if GetType was called on Base, we'd treat it same as GetType on Derived. This was resulting in marking too much and too little (we'd mark right away when we saw GetType call, irrespective of the MethodTable existence, and we wouldn't walk down to Base if the GetType was called on Derived.

The fix is to use two node types. One simply tracks "GetType was called on something". It doesn't bring any other dependencies with it. We only use it to condition other nodes. The other node represents "the dependencies from the annotations".

The way this works is:
* We see GetType called on Base, so we add ObjectGetTypeCalledNode for Base.
* We generate MethodTable for Derived, which adds a conditional dependency on ObjectGetTypeCalledNode of Derived if ObjectGetTypeCalledNode of Base is in the graph. (This ensures "walking up the hierarchy".)
* MethodTable of Derived also adds a conditional dependency on ObjectGetTypeFlowDependenciesNode of Derived if ObjectGetTypeCalledNode of Derived is part of the graph. This will do the actual marking but only if the MethodTable and GetType call was seen.
* ObjectGetTypeFlowDependenciesNode also "walks down the hierarchy" and makes sure ObjectGetTypeFlowDependenciesNode of all the bases and interfaces are present in the graph.

This happens to also address #110563. Because of that, I had to update tests since ILC started trimming more stuff without seeing the type as constructed.
    @MichalStrehovsky
    MichalStrehovsky authored Dec 17, 2024
    Configuration menu
    Copy the full SHA
    6d6f2bd View commit details
    Browse the repository at this point in the history

  7. [wasm] Fix templates patch in the bench (#110779) 

    The templates were updated recently. It also updates the copying of the files again as the tfm's are in sync now.
    @radekdoulik
    radekdoulik authored Dec 17, 2024
    Configuration menu
    Copy the full SHA
    040cbe2 View commit details
    Browse the repository at this point in the history
Loading