Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: d32b461219
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 73229ad781
Choose a head ref
  • 16 commits
  • 102 files changed
  • 18 contributors

Commits on Sep 9, 2024

  1. Fix corner-case accounting bug in new codeheap allocation (#107514)

    The size of internal CodeHeap structures was not included in
    codeheap memory reservation. It caused false OOM exception to
    be thrown when JITed method code size was near 64kB multiple
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    github-actions[bot] and jkotas authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d30807e View commit details
    Browse the repository at this point in the history
  2. Implement getClassAssemblyName (#106959) (#107516)

    * Add getClassAssemblyName
    
    * Handle nullptrs
    
    * Remove CORINFO_ASSEMBLY_HANDLE
    
    * Address feedbacks
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    hez2010 and jkotas authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    05d54b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Include system environment variables when resolving ASPNETCORE_URLS (#…

    …107392)
    
    Co-authored-by: Marek Fišera <mara@neptuo.com>
    github-actions[bot] and maraf authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    30eaaf2 View commit details
    Browse the repository at this point in the history
  2. [release/9.0] Fix thread static cleanup paths (#107554)

    * Fix thread static cleanup paths - Do not destroy GC handles while holding the spin lock - Free the pLoaderHandle array when the thread is terminated
    
    * Fix assert
    
    * When using a ThreadStatics stress test on collectible assemblies, a few more issues were found - Fix issue where the LoaderAllocator's SegmentedHandleIndex wasn't being freed - Fix issue where the logic to re-use TLSIndex values wasn't working properly
    
    ---------
    
    Co-authored-by: David Wrighton <davidwr@microsoft.com>
    github-actions[bot] and davidwrighton authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    751df15 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. [release/9.0] Consider existence of EETypes and metadata for typeof c…

    …hecks (#107598)
    
    Under some circumstances, the compiler could assume code under if (someType == typeof(Foo)) is unreachable and optimize it into an infinite loop. This can happen when type Foo was only visible in metadata and not actually used at runtime.
    
    Fixes #107300.
    
    ---------
    
    Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
    github-actions[bot] and MichalStrehovsky authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    cd064dd View commit details
    Browse the repository at this point in the history
  2. [release/9.0] Track that kmov instructions may write to GPR register (#…

    …107476)
    
    * kmov*_gpr writes to gpr
    
    * add test
    
    * Add using
    
    ---------
    
    Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
    Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    3 people authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b2d53cc View commit details
    Browse the repository at this point in the history
  3. [release/9.0] JIT ARM64: Don't emit mov for zero case in jump table…

    …s for shift intrinsics (#107487)
    
    * Don't emit mov for zero shift amount
    
    * Add test
    
    * Revert "Don't emit mov for zero shift amount"
    
    This reverts commit cd2656f.
    
    * Don't emit mov for zero left-shift amount
    
    * Update test
    
    * Use fallback intrinsic for >> by zero; remove mov special case
    
    * Feedback
    
    ---------
    
    Co-authored-by: Aman Khalid (from Dev Box) <amankhalid@microsoft.com>
    Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    3 people authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    972562c View commit details
    Browse the repository at this point in the history
  4. JIT: don't create vector constants from relocatable constants (#107500)

    We can't represent relocations in data currently.
    
    Fixes #107396.
    
    Co-authored-by: Andy Ayers <andya@microsoft.com>
    Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    3 people authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    fd36441 View commit details
    Browse the repository at this point in the history
  5. [release/9.0] ARM64-SVE: Allow op inside conditionalselect to be non …

    …HWintrinsic (#107581)
    
    * ARM64-SVE: Allow op inside conditionselect to be non HWintrinsic
    
    * Add Sve.IsSupported check to test
    
    ---------
    
    Co-authored-by: Alan Hayward <alan.hayward@arm.com>
    Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    3 people authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3de6ae2 View commit details
    Browse the repository at this point in the history
  6. [release/9.0] Arm: Fix the base register used for restoring register …

    …from stack (#107584)
    
    * Use correct baseReg for vstr, similar to vldr
    
    * add test cases
    
    * Mark internal test methods private
    
    ---------
    
    Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
    Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    3 people authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    35e3c87 View commit details
    Browse the repository at this point in the history
  7. Fix SSP issue with HW exceptions from JIT helpers (#107676)

    The recent change that was fixing bad SSP updating during exception
    handling with funceval has also modified the way SSP is extracted for
    hardware exceptions. That works fine for many cases, but there is a
    problem when the exception occurs in a JIT helper. The
    `AjustContextForJITHelpers` uses only the basic `CONTEXT` structure for
    unwinding to the managed caller and so the SSP is not properly updated.
    That makes it off by one slot when we set it when continuing execution
    after catch.
    This change removes storing SSP for hardware exceptions in the
    FaultingExceptionFrame to mitigate the issue. It effectively returns to
    the way software exceptions use - scanning shadow stack for the
    instruction pointer of the frame to which it is going to resume after
    catch.
    
    Co-authored-by: Jan Vorlicek <jan.vorlicek@volny,cz>
    Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    3 people authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3b4a3e8 View commit details
    Browse the repository at this point in the history
  8. Fix IL reference tokens to another generated assembly members (#107691)

    Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
    github-actions[bot] and buyaa-n authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    8dc3e06 View commit details
    Browse the repository at this point in the history
  9. add _requiresAlign8 to company and mangled name (#107701)

    Co-authored-by: yowl <scott.waye@hubse.com>
    github-actions[bot] and yowl authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9abc5de View commit details
    Browse the repository at this point in the history
  10. Disable subset of the stack overflow tests on ARM (#107721)

    There is a problem with the variant of the stack overflow test that can
    overflow in a native function on ARM. The EHABI unwind info is not
    present for leaf functions and libunwind is unable to unwind from the
    failure location to the first managed frame.
    
    I've created an issue (#107184) for the underlying problem. This PR
    disables that test variant until the problem is fixed.
    
    Close #106742
    
    Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
    github-actions[bot] and janvorli authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3104ebb View commit details
    Browse the repository at this point in the history
  11. [release/9.0] Fix config source gen binding value types to null confi…

    …guration values (#107670)
    
    * Fix config source gen binding value types to null configuration values
    
    * Address the feedback
    
    ---------
    
    Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
    github-actions[bot] and tarekgh authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9bf6440 View commit details
    Browse the repository at this point in the history
  12. [release/9.0] Fix config source gen binding with SslClientAuthenticat…

    …ionOptions (#107705)
    
    * Fix config source gen binding with SslClientAuthenticationOptions
    
    * Apply suggestions from code review
    
    Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
    
    ---------
    
    Co-authored-by: Tarek Mahmoud Sayed <tarekms@microsoft.com>
    Co-authored-by: Tarek Mahmoud Sayed <10833894+tarekgh@users.noreply.github.com>
    Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
    4 people authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    73229ad View commit details
    Browse the repository at this point in the history
Loading