Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b10f5c9d
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1c4755da
Choose a head ref
  • 13 commits
  • 51 files changed
  • 10 contributors

Commits on Sep 6, 2024

  1. codeql fixes (#107422) 

    * codeql fix

* explicitly null terminating the status
    @mangod9
    mangod9 authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1bad124 View commit details
    Browse the repository at this point in the history

  2. Enable more BinaryFormatter tests (#107408) 

    * enable the BinaryFormatter tests in System.Runtime.Serialization.Formatters.Tests

* add new test project, where the flag is disabled and it runs only 3 tests in total that ensure that

* The SerializationGuard is no longer activated since BF was moved to the OOB package, the tests need to reflect that.
    @adamsitnik
    adamsitnik authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8685859 View commit details
    Browse the repository at this point in the history

  3. Add NrbfDecoder Fuzzer (#107385)

    @buyaa-n
    buyaa-n authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1f6a0d4 View commit details
    Browse the repository at this point in the history

  4. Make ComponentActivator.[LoadAssemblyAnd]GetFunctionPointer set initi… 

    …alize out pointer to 0 (#107426)
    @elinor-fung
    elinor-fung authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d4601d3 View commit details
    Browse the repository at this point in the history

  5. Make Module::LoadAssembly return Assembly instead of DomainAssembly (#… 

    …107411)

- Switch `Module::LoadAssembly` to return `Assembly` instead of `DomainAssembly`
- Remove unnecessary parameter on Module::GetAssemblyIfLoaded
- Remove `AssemblySpec::LoadDomainAssembly` - make callers use `AssemblySpec::LoadAssembly` instead
    @elinor-fung
    elinor-fung authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    42f3dce View commit details
    Browse the repository at this point in the history

  6. JIT: Simplify block insertion logic during loop compaction (#107403)

    @amanasifkhalid
    amanasifkhalid authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    cf8cbe9 View commit details
    Browse the repository at this point in the history

  7. Fix leaking EVP_MAC_CTX in one shot

    @vcsjones
    vcsjones authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    5a6d100 View commit details
    Browse the repository at this point in the history

  8. Remove thread contention from Activity Start/Stop (#107333) 

    * Remove thread contention from Activity Start/Stop

Author:    algorithmsarecool <algorithmsarecool@gmail.com>

* Fix ref parameters and whitespace

Author:    algorithmsarecool<algorithmsarecool@gmail.com>

* PR feedback.
- Reduce duplication
- add comments and make code more obvious
- Use IndexOf

Author:    algorithmsarecool <algorithmsarecool@gmail.com>

* PR feedback to simplify locking strategy

* PR feedback, final nits
    @AlgorithmsAreCool
    AlgorithmsAreCool authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ad430a1 View commit details
    Browse the repository at this point in the history

  9. Move pinned heap handle table from BaseDomain to AppDomain and ma… 

    …ke callers go through the `AppDomain` (#107420)

- Move the pinned heap handle table to `AppDomain`
  - This does make the current use in the `GlobalLoaderAllocator` (went through `SystemDomain`) and in EnC adding a static field (went through `AppDomain`) use the same table. They have the same lifetime.
- Move `GetLoaderAllocator` (it already always returns the global one), `IsStringInterned`, `GetOrInternString`  functions from `BaseDomain` to `AppDomain`
    @elinor-fung
    elinor-fung authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6092b21 View commit details
    Browse the repository at this point in the history

  10. Fix swizzle_mask type (#107460) 

    That was catched by llvm debug asserts, the mask should be vector of 16 int8
    @radekdoulik
    radekdoulik authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    dc5dbab View commit details
    Browse the repository at this point in the history

  11. [NRBF] Fix bugs discovered by the fuzzer (#107368) 

    * bug #1: don't allow for values out of the SerializationRecordType enum range

* bug #2: throw SerializationException rather than KeyNotFoundException when the referenced record is missing or it points to a record of different type

* bug #3: throw SerializationException rather than FormatException when it's being thrown by BinaryReader (or sth else that we use)

* bug #4: document the fact that IOException can be thrown

* bug #5: throw SerializationException rather than OverflowException when parsing the decimal fails

* bug #6: 0 and 17 are illegal values for PrimitiveType enum

* bug #7: throw SerializationException when a surrogate character is read (so far an ArgumentException was thrown)
    @adamsitnik
    adamsitnik authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e79426e View commit details
    Browse the repository at this point in the history

  12. Bind the code alignment condition with the loop alignment condition (#… 

    …107340)
    @filipnavara
    filipnavara authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d1ecd63 View commit details
    Browse the repository at this point in the history

  13. Fix SegmentResortChains synchronization (#107468)

    @ChrisAhna
    ChrisAhna authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1c4755d View commit details
    Browse the repository at this point in the history
Loading