Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0a5cccb579
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d0f3235d31
Choose a head ref
  • 6 commits
  • 23 files changed
  • 9 contributors

Commits on Aug 29, 2024

  1. [release/9.0] Ensure the layout of StackAllocatedBox<T> matches box…

    …ed layouts (#107075)
    
    * Ensure the layout of `StackAllocatedBox<T>` matches boxed layouts
    
    The boxed layout of a struct always has its data at +8, as evidenced by
    `Object::UnBox`. This means that `StackAllocatedBox<T>` should have
    `Pack = 1`, otherwise this may not be the case. In the test failure we
    had a `StackAllocatedBox<Int128>` which had its `_value` field at offset
    16. After object stack allocation this meant that we were saving data in
    padding of the structure, which promotion does not guarantee to
    preserve.
    
    Fix #106947
    
    * Run jit-format
    
    * Correct enum
    
    ---------
    
    Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
    Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    3 people authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    6c8b1ed View commit details
    Browse the repository at this point in the history
  2. Ensure that AdvSimd.Insert doesn't zero out the upper bits (#107089)

    Co-authored-by: Tanner Gooding <tagoo@outlook.com>
    Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    3 people authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    c827c27 View commit details
    Browse the repository at this point in the history
  3. Fix storage of stack trace of exception from reflection (#107093)

    There was one more case where we have saved the stack trace into the _remoteStackTraceString
    field in the exception when the exception was passing from reflection invoked code
    to the caller of that code. While there is no visible difference in the Exception.ToString,
    a SOS test was failing due to that. And it is not necessary to save the stack trace
    there.
    
    I have thought about the cases when we really need the stack trace saved into the
    _remoteStackTraceString and I believe that actually the only case is when an existing
    exception is thrown again in managed code. So I have removed the option to save the stack
    trace from all the variants of the DispatchManagedException.
    
    Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
    Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
    3 people authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    13c6579 View commit details
    Browse the repository at this point in the history
  4. [release/9.0] Tensor Operation fixes when input is sliced (non-contig…

    …uous) (#107097)
    
    * slicing fixes
    
    * rebased on main
    
    ---------
    
    Co-authored-by: Michael Sharp <misharp@microsoft.com>
    github-actions[bot] and michaelgsharp authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    00f3f3e View commit details
    Browse the repository at this point in the history
  5. [release/9.0] Azure Linux 3.0 and test fixes (#107123)

    * Change BuildWithFactoryReadDirect to not use RSA+MD5
    
    * Add Azure 3.0 helix test
    
    ---------
    
    Co-authored-by: Kevin Jones <kevin@vcsjones.com>
    Co-authored-by: Rich Lander <rlander@microsoft.com>
    3 people authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    33a17bb View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Use the typical MethodTable not the instantiated one. (#107160)

    Co-authored-by: Aaron R Robinson <arobins@microsoft.com>
    github-actions[bot] and AaronRobinsonMSFT authored Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d0f3235 View commit details
    Browse the repository at this point in the history
Loading